mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Repair problem with listing rules that have a WHERE condition and

Browse Source 
have an INSERT...SELECT as the first or only action.  Per bug report
from Sergio Pili.
This commit is contained in:
Tom Lane 2001-11-26 00:29:15 +00:00
parent 4bc8c8dd95
commit e59334994e
1 changed files with 20 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/backend/utils/adt/ruleutils.c
View File

@ -3,7 +3,7 @@
* back to source text * back to source text
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/utils/adt/ruleutils.c,v 1.87 2001/11/19 19:51:20 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/utils/adt/ruleutils.c,v 1.88 2001/11/26 00:29:15 tgl Exp $
* *
* This software is copyrighted by Jan Wieck - Hamburg. * This software is copyrighted by Jan Wieck - Hamburg.
* *
@ -178,9 +178,9 @@ pg_get_ruledef(PG_FUNCTION_ARGS)
elog(ERROR, "get_ruledef: cannot connect to SPI manager"); elog(ERROR, "get_ruledef: cannot connect to SPI manager");
/* /*
* On the first call prepare the plan to lookup pg_proc. We read * On the first call prepare the plan to lookup pg_rewrite. We read
* pg_proc over the SPI manager instead of using the syscache to be * pg_rewrite over the SPI manager instead of using the syscache to be
* checked for read access on pg_proc. * checked for read access on pg_rewrite.
*/ */
if (plan_getrule == NULL) if (plan_getrule == NULL)
{ {
@ -271,9 +271,9 @@ pg_get_viewdef(PG_FUNCTION_ARGS)
elog(ERROR, "get_viewdef: cannot connect to SPI manager"); elog(ERROR, "get_viewdef: cannot connect to SPI manager");
/* /*
* On the first call prepare the plan to lookup pg_proc. We read * On the first call prepare the plan to lookup pg_rewrite. We read
* pg_proc over the SPI manager instead of using the syscache to be * pg_rewrite over the SPI manager instead of using the syscache to be
* checked for read access on pg_proc. * checked for read access on pg_rewrite.
*/ */
if (plan_getview == NULL) if (plan_getview == NULL)
{ {
@ -769,8 +769,21 @@ make_ruledef(StringInfo buf, HeapTuple ruletup, TupleDesc rulettc)
appendStringInfo(buf, " WHERE "); appendStringInfo(buf, " WHERE ");
qual = stringToNode(ev_qual); qual = stringToNode(ev_qual);
/*
* We need to make a context for recognizing any Vars in the qual
* (which can only be references to OLD and NEW). Use the rtable
* of the first query in the action list for this purpose.
*/
query = (Query *) lfirst(actions); query = (Query *) lfirst(actions);
/*
* If the action is INSERT...SELECT, OLD/NEW have been pushed
* down into the SELECT, and that's what we need to look at.
* (Ugly kluge ... try to fix this when we redesign querytrees.)
*/
query = getInsertSelectQuery(query, NULL);
context.buf = buf; context.buf = buf;
context.namespaces = makeList1(&dpns); context.namespaces = makeList1(&dpns);
context.varprefix = (length(query->rtable) != 1); context.varprefix = (length(query->rtable) != 1);