mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve relcache.c error reporting for the next guy who has to debug

Browse Source 
this thing.
This commit is contained in:
Bruce Momjian 2002-07-15 01:57:51 +00:00
parent 91dfa1af97
commit e552e9e512
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/backend/utils/cache/relcache.c vendored
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/utils/cache/relcache.c,v 1.166 2002/07/12 18:43:18 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/utils/cache/relcache.c,v 1.167 2002/07/15 01:57:51 momjian Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -238,12 +238,12 @@ do { \
(void *)&(RELATION->rd_id), \ (void *)&(RELATION->rd_id), \
HASH_REMOVE, NULL); \ HASH_REMOVE, NULL); \
if (idhentry == NULL) \ if (idhentry == NULL) \
elog(WARNING, "trying to delete a reldesc that does not exist."); \ elog(WARNING, "trying to delete a rd_id reldesc that does not exist."); \
nodentry = (RelNodeCacheEnt*)hash_search(RelationNodeCache, \ nodentry = (RelNodeCacheEnt*)hash_search(RelationNodeCache, \
(void *)&(RELATION->rd_node), \ (void *)&(RELATION->rd_node), \
HASH_REMOVE, NULL); \ HASH_REMOVE, NULL); \
if (nodentry == NULL) \ if (nodentry == NULL) \
elog(WARNING, "trying to delete a reldesc that does not exist."); \ elog(WARNING, "trying to delete a rd_node reldesc that does not exist."); \
if (IsSystemNamespace(RelationGetNamespace(RELATION))) \ if (IsSystemNamespace(RelationGetNamespace(RELATION))) \
{ \ { \
char *relname = RelationGetRelationName(RELATION); \ char *relname = RelationGetRelationName(RELATION); \
@ -252,7 +252,7 @@ do { \
relname, \ relname, \
HASH_REMOVE, NULL); \ HASH_REMOVE, NULL); \
if (namehentry == NULL) \ if (namehentry == NULL) \
elog(WARNING, "trying to delete a reldesc that does not exist."); \ elog(WARNING, "trying to delete a relname reldesc that does not exist."); \
} \ } \
} while(0) } while(0)
@ -276,7 +276,7 @@ static HTAB *OpClassCache = NULL;
/* non-export function prototypes */ /* non-export function prototypes */
static void RelationClearRelation(Relation relation, bool rebuildIt); static void RelationClearRelation(Relation relation, bool rebuild);
#ifdef ENABLE_REINDEX_NAILED_RELATIONS #ifdef ENABLE_REINDEX_NAILED_RELATIONS
static void RelationReloadClassinfo(Relation relation); static void RelationReloadClassinfo(Relation relation);
@ -1652,7 +1652,7 @@ RelationReloadClassinfo(Relation relation)
* it's told to do; callers must determine which they want. * it's told to do; callers must determine which they want.
*/ */
static void static void
RelationClearRelation(Relation relation, bool rebuildIt) RelationClearRelation(Relation relation, bool rebuild)
{ {
MemoryContext oldcxt; MemoryContext oldcxt;
@ -1719,7 +1719,7 @@ RelationClearRelation(Relation relation, bool rebuildIt)
* moving the physical RelationData record (so that the someone's * moving the physical RelationData record (so that the someone's
* pointer is still valid). * pointer is still valid).
*/ */
if (!rebuildIt) if (!rebuild)
{ {
/* ok to zap remaining substructure */ /* ok to zap remaining substructure */
FreeTupleDesc(relation->rd_att); FreeTupleDesc(relation->rd_att);
@ -1806,7 +1806,7 @@ RelationClearRelation(Relation relation, bool rebuildIt)
static void static void
RelationFlushRelation(Relation relation) RelationFlushRelation(Relation relation)
{ {
bool rebuildIt; bool rebuild;
if (relation->rd_myxactonly) if (relation->rd_myxactonly)
{ {
@ -1814,17 +1814,17 @@ RelationFlushRelation(Relation relation)
* Local rels should always be rebuilt, not flushed; the relcache * Local rels should always be rebuilt, not flushed; the relcache
* entry must live until RelationPurgeLocalRelation(). * entry must live until RelationPurgeLocalRelation().
*/ */
rebuildIt = true; rebuild = true;
} }
else else
{ {
/* /*
* Nonlocal rels can be dropped from the relcache if not open. * Nonlocal rels can be dropped from the relcache if not open.
*/ */
rebuildIt = !RelationHasReferenceCountZero(relation); rebuild = !RelationHasReferenceCountZero(relation);
} }
RelationClearRelation(relation, rebuildIt); RelationClearRelation(relation, rebuild);
} }
/* /*