mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

amcheck: In verify_heapam, allows tuples with xmin 0.

Browse Source 
Commit e88754a1965c0f40a723e6e46d670cacda9e19bd caused that case
to be reported as corruption, but Peter Geoghegan pointed out that
it can legitimately happen in the case of a speculative insertion
that aborts, so we'd better not flag it as corruption after all.

Back-patch to v14, like the commit that introduced the issue.

Discussion: http://postgr.es/m/CAH2-WzmEabzcPTxSY-NXKH6Qt3FkAPYHGQSe2PtvGgj17ZQkCw@mail.gmail.com
This commit is contained in:
Robert Haas 2023-03-28 16:16:53 -04:00
parent c6f1f4e443
commit e3363cda9c
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
contrib/amcheck/verify_heapam.c
View File

@ -774,8 +774,7 @@ check_tuple_visibility(HeapCheckContext *ctx)
switch (get_xid_status(xmin, ctx, &xmin_status)) switch (get_xid_status(xmin, ctx, &xmin_status))
{ {
case XID_INVALID: case XID_INVALID:
report_corruption(ctx, /* Could be the result of a speculative insertion that aborted. */
pstrdup("xmin is invalid"));
return false; return false;
case XID_BOUNDS_OK: case XID_BOUNDS_OK:
break; break;