mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Suppress more variable-set-but-not-used warnings from clang 15.

Browse Source 
Mop up assorted set-but-not-used warnings in the back branches.
This includes back-patching relevant fixes from commit 152c9f7b8
the rest of the way, but there are also several cases that did not
appear in HEAD.  Some of those we'd fixed in a retail way but not
back-patched, and others I think just got rewritten out of existence
during nearby refactoring.

While here, also back-patch b1980f6d0 (PL/Tcl: Fix compiler warnings
with Tcl 8.6) into 9.2, so that that branch compiles warning-free
with modern Tcl.

Per project policy, this is a candidate for back-patching into
out-of-support branches: it suppresses annoying compiler warnings
but changes no behavior.  Hence, back-patch all the way to 9.2.

Discussion: https://postgr.es/m/514615.1663615243@sss.pgh.pa.us
This commit is contained in:
Tom Lane 2022-09-21 13:52:38 -04:00
parent 43f72e0f73
commit db8e36682d
2 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/backend/optimizer/util/var.c
View File

@ -773,16 +773,13 @@ flatten_join_alias_vars_mutator(Node *node,
RowExpr *rowexpr; RowExpr *rowexpr;
List *fields = NIL; List *fields = NIL;
List *colnames = NIL; List *colnames = NIL;
AttrNumber attnum;
ListCell *lv; ListCell *lv;
ListCell *ln; ListCell *ln;
attnum = 0;
Assert(list_length(rte->joinaliasvars) == list_length(rte->eref->colnames)); Assert(list_length(rte->joinaliasvars) == list_length(rte->eref->colnames));
forboth(lv, rte->joinaliasvars, ln, rte->eref->colnames) forboth(lv, rte->joinaliasvars, ln, rte->eref->colnames)
{ {
newvar = (Node *) lfirst(lv); newvar = (Node *) lfirst(lv);
attnum++;
/* Ignore dropped columns */ /* Ignore dropped columns */
if (newvar == NULL) if (newvar == NULL)
continue; continue;

4
src/backend/utils/cache/relcache.c vendored
View File

@ -4373,7 +4373,6 @@ AttrDefaultFetch(Relation relation)
HeapTuple htup; HeapTuple htup;
Datum val; Datum val;
bool isnull; bool isnull;
int found;
int i; int i;
ScanKeyInit(&skey, ScanKeyInit(&skey,
@ -4384,7 +4383,6 @@ AttrDefaultFetch(Relation relation)
adrel = table_open(AttrDefaultRelationId, AccessShareLock); adrel = table_open(AttrDefaultRelationId, AccessShareLock);
adscan = systable_beginscan(adrel, AttrDefaultIndexId, true, adscan = systable_beginscan(adrel, AttrDefaultIndexId, true,
NULL, 1, &skey); NULL, 1, &skey);
found = 0;
while (HeapTupleIsValid(htup = systable_getnext(adscan))) while (HeapTupleIsValid(htup = systable_getnext(adscan)))
{ {
@ -4399,8 +4397,6 @@ AttrDefaultFetch(Relation relation)
elog(WARNING, "multiple attrdef records found for attr %s of rel %s", elog(WARNING, "multiple attrdef records found for attr %s of rel %s",
NameStr(attr->attname), NameStr(attr->attname),
RelationGetRelationName(relation)); RelationGetRelationName(relation));
else
found++;
val = fastgetattr(htup, val = fastgetattr(htup,
Anum_pg_attrdef_adbin, Anum_pg_attrdef_adbin,