mirrors
/
postgres
mirror of https://github.com/postgres/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix generation of padding message before encrypting Elgamal in pgcrypto 

fe0a0b5, which has added a stronger random source in Postgres, has
introduced a thinko when creating a padding message which gets encrypted
for Elgamal.  The padding message cannot have zeros, which are replaced
by random bytes.  However if pg_strong_random() failed, the message
would finish by being considered in correct shape for encryption with
zeros.

Author: Tom Lane
Reviewed-by: Michael Paquier
Discussion: https://postgr.es/m/20186.1546188423@sss.pgh.pa.us
Backpatch-through: 10
This commit is contained in:
Michael Paquier 2019-01-01 10:39:19 +09:00
parent 8d3b389ec3
commit d880b208e5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/pgcrypto/pgp-pubenc.c
View File

@ -66,7 +66,7 @@ pad_eme_pkcs1_v15(uint8 *data, int data_len, int res_len, uint8 **res_p)
{ {
px_memset(buf, 0, res_len); px_memset(buf, 0, res_len);
px_free(buf); px_free(buf);
break; return PXE_NO_RANDOM;
} }
} }
if (*p != 0) if (*p != 0)