From d5873aaec789dc4c17ca54f0b0b79707fce84219 Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Tue, 19 Dec 2023 14:13:50 +0100 Subject: [PATCH] doc: Fix syntax in ALTER FOREIGN DATA WRAPPER example The example for dropping an option was incorrectly quoting the option key thus making it a value turning the command into an unqualified ADD operation. The result of dropping became adding a new key/value pair instead: d=# alter foreign data wrapper f options (drop 'b'); ALTER FOREIGN DATA WRAPPER d=# select fdwoptions from pg_foreign_data_wrapper where fdwname='f'; fdwoptions ------------ {drop=b} (1 row) This has been incorrect for a long time so backpatch to all supported branches. Author: Tim Discussion: https://postgr.es/m/170292280173.1876505.5204623074024041738@wrigleys.postgresql.org --- doc/src/sgml/ref/alter_foreign_data_wrapper.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/ref/alter_foreign_data_wrapper.sgml b/doc/src/sgml/ref/alter_foreign_data_wrapper.sgml index 54f34c2c01..dc0957d965 100644 --- a/doc/src/sgml/ref/alter_foreign_data_wrapper.sgml +++ b/doc/src/sgml/ref/alter_foreign_data_wrapper.sgml @@ -153,7 +153,7 @@ ALTER FOREIGN DATA WRAPPER name REN Change a foreign-data wrapper dbi, add option foo, drop bar: -ALTER FOREIGN DATA WRAPPER dbi OPTIONS (ADD foo '1', DROP 'bar'); +ALTER FOREIGN DATA WRAPPER dbi OPTIONS (ADD foo '1', DROP bar);