mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add HINT for restartpoint race with KeepFileRestoredFromArchive().

Browse Source 
The five commits ending at cc2c7d65fc27e877c9f407587b0b92d46cd6dd16
closed this race condition for v15+.  For v14 through v10, add a HINT to
discourage studying the cosmetic problem.

Reviewed by Kyotaro Horiguchi and David Steele.

Discussion: https://postgr.es/m/20220731061747.GA3692882@rfd.leadboat.com
This commit is contained in:
Noah Misch 2022-08-05 08:30:58 -07:00
parent 91130dd316
commit cf86fddc1c
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/access/transam/xlog.c
View File

@ -3381,7 +3381,10 @@ XLogFileInit(XLogSegNo logsegno, bool *use_existent, bool use_lock)
if (fd < 0) if (fd < 0)
ereport(ERROR, ereport(ERROR,
(errcode_for_file_access(), (errcode_for_file_access(),
errmsg("could not open file \"%s\": %m", path))); errmsg("could not open file \"%s\": %m", path),
(AmCheckpointerProcess() ?
errhint("This is known to fail occasionally during archive recovery, where it is harmless.") :
0)));
elog(DEBUG2, "done creating and filling new WAL file"); elog(DEBUG2, "done creating and filling new WAL file");

10
src/backend/storage/file/fd.c
View File

@ -753,7 +753,10 @@ durable_link_or_rename(const char *oldfile, const char *newfile, int elevel)
ereport(elevel, ereport(elevel,
(errcode_for_file_access(), (errcode_for_file_access(),
errmsg("could not link file \"%s\" to \"%s\": %m", errmsg("could not link file \"%s\" to \"%s\": %m",
oldfile, newfile))); oldfile, newfile),
(AmCheckpointerProcess() ?
errhint("This is known to fail occasionally during archive recovery, where it is harmless.") :
0)));
return -1; return -1;
} }
unlink(oldfile); unlink(oldfile);
@ -764,7 +767,10 @@ durable_link_or_rename(const char *oldfile, const char *newfile, int elevel)
ereport(elevel, ereport(elevel,
(errcode_for_file_access(), (errcode_for_file_access(),
errmsg("could not rename file \"%s\" to \"%s\": %m", errmsg("could not rename file \"%s\" to \"%s\": %m",
oldfile, newfile))); oldfile, newfile),
(AmCheckpointerProcess() ?
errhint("This is known to fail occasionally during archive recovery, where it is harmless.") :
0)));
return -1; return -1;
} }
#endif #endif