mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix incorrect comment about nbtree WAL record.

Browse Source 
The nbtree VACUUM WAL record stores its page offset number payload in
blk 0 (just like the closely related nbtree DELETE WAL record).  Commit
ebd551f5 fixed a similar issue with the DELETE WAL record, but missed
this one.
This commit is contained in:
Peter Geoghegan 2023-04-17 09:58:18 -07:00
parent d48ac0070c
commit cd7cdc550c
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/include/access/nbtxlog.h
View File

@ -201,7 +201,7 @@ typedef struct xl_btree_reuse_page
* when btinsert() is called. * when btinsert() is called.
* *
* The records are very similar. The only difference is that xl_btree_delete * The records are very similar. The only difference is that xl_btree_delete
* has a snapshotConflictHorizon field to generate recovery conflicts. * have snapshotConflictHorizon/isCatalogRel fields for recovery conflicts.
* (VACUUM operations can just rely on earlier conflicts generated during * (VACUUM operations can just rely on earlier conflicts generated during
* pruning of the table whose TIDs the to-be-deleted index tuples point to. * pruning of the table whose TIDs the to-be-deleted index tuples point to.
* There are also small differences between each REDO routine that we don't go * There are also small differences between each REDO routine that we don't go
@ -225,9 +225,13 @@ typedef struct xl_btree_vacuum
uint16 ndeleted; uint16 ndeleted;
uint16 nupdated; uint16 nupdated;
/* DELETED TARGET OFFSET NUMBERS FOLLOW */ /*----
/* UPDATED TARGET OFFSET NUMBERS FOLLOW */ * In payload of blk 0 :
/* UPDATED TUPLES METADATA (xl_btree_update) ARRAY FOLLOWS */ * - DELETED TARGET OFFSET NUMBERS
* - UPDATED TARGET OFFSET NUMBERS
* - UPDATED TUPLES METADATA (xl_btree_update) ITEMS
*----
*/
} xl_btree_vacuum; } xl_btree_vacuum;
#define SizeOfBtreeVacuum (offsetof(xl_btree_vacuum, nupdated) + sizeof(uint16)) #define SizeOfBtreeVacuum (offsetof(xl_btree_vacuum, nupdated) + sizeof(uint16))
@ -244,7 +248,7 @@ typedef struct xl_btree_delete
* In payload of blk 0 : * In payload of blk 0 :
* - DELETED TARGET OFFSET NUMBERS * - DELETED TARGET OFFSET NUMBERS
* - UPDATED TARGET OFFSET NUMBERS * - UPDATED TARGET OFFSET NUMBERS
* - UPDATED TUPLES METADATA (xl_btree_update) ARRAY * - UPDATED TUPLES METADATA (xl_btree_update) ITEMS
*---- *----
*/ */
} xl_btree_delete; } xl_btree_delete;