mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove a couple of useless pstrdup() calls.

Browse Source 
There's no point in pstrdup'ing the result of TextDatumGetCString,
since that's necessarily already a freshly-palloc'd C string.

These particular calls are unlikely to be of any consequence
performance-wise, but still they're a bad precedent that can confuse
future patch authors.

Noted by Chapman Flack.
This commit is contained in:
Tom Lane 2016-03-09 23:29:05 -05:00
parent 1d4a0ab19a
commit cc402116ca
1 changed files with 2 additions and 2 deletions

4
src/backend/foreign/foreign.c

@ -121,14 +121,14 @@ GetForeignServer(Oid serverid)
tp,
Anum_pg_foreign_server_srvtype,
&isnull);
server->servertype = isnull ? NULL : pstrdup(TextDatumGetCString(datum));
server->servertype = isnull ? NULL : TextDatumGetCString(datum);
/* Extract server version */
datum = SysCacheGetAttr(FOREIGNSERVEROID,
tp,
Anum_pg_foreign_server_srvversion,
&isnull);
server->serverversion = isnull ? NULL : pstrdup(TextDatumGetCString(datum));
server->serverversion = isnull ? NULL : TextDatumGetCString(datum);
/* Extract the srvoptions */
datum = SysCacheGetAttr(FOREIGNSERVEROID,