mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary pstrdup in fetch_table_list.

Browse Source 
The result of TextDatumGetCString is already palloc'ed so we don't need to
allocate memory for it again. We decide not to backpatch it as there
doesn't seem to be any case where it can create a meaningful leak.

Author: Zhijie Hou
Reviewed-by: Daniel Gustafsson
Discussion: https://postgr.es/m/229fed2eb8c54c71a96ccb99e516eb12@G08CNEXMBPEKD05.g08.fujitsu.local
This commit is contained in:
Amit Kapila 2021-01-16 10:15:32 +05:30
parent c9a0dc3486
commit c95765f476
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/commands/subscriptioncmds.c
View File

@ -1267,7 +1267,7 @@ fetch_table_list(WalReceiverConn *wrconn, List *publications)
relname = TextDatumGetCString(slot_getattr(slot, 2, &isnull)); relname = TextDatumGetCString(slot_getattr(slot, 2, &isnull));
Assert(!isnull); Assert(!isnull);
rv = makeRangeVar(pstrdup(nspname), pstrdup(relname), -1); rv = makeRangeVar(nspname, relname, -1);
tablelist = lappend(tablelist, rv); tablelist = lappend(tablelist, rv);
ExecClearTuple(slot); ExecClearTuple(slot);