mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Hello,

Browse Source 
here is the patch attached which do check in each BLOB operation, if we are
in transaction, and raise an error otherwise. This will prevent such mistakes.

--
Sincerely Yours,
Denis Perchine
This commit is contained in:
Bruce Momjian 2001-01-21 03:49:14 +00:00
parent 023a48b811
commit c655935217
1 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/backend/storage/large_object/inv_api.c
View File

@ -9,7 +9,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/storage/large_object/inv_api.c,v 1.80 2000/11/02 23:52:06 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/storage/large_object/inv_api.c,v 1.81 2001/01/21 03:49:14 momjian Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -64,6 +64,9 @@ inv_create(int flags)
Oid file_oid; Oid file_oid;
LargeObjectDesc *retval; LargeObjectDesc *retval;
if (!IsTransactionBlock())
elog(ERROR, "inv_create: Not in transaction. BLOBs should be used inside transaction.");
/* /*
* Allocate an OID to be the LO's identifier. * Allocate an OID to be the LO's identifier.
*/ */
@ -117,6 +120,9 @@ inv_open(Oid lobjId, int flags)
{ {
LargeObjectDesc *retval; LargeObjectDesc *retval;
if (!IsTransactionBlock())
elog(ERROR, "inv_open: Not in transaction. BLOBs should be used inside transaction.");
if (! LargeObjectExists(lobjId)) if (! LargeObjectExists(lobjId))
elog(ERROR, "inv_open: large object %u not found", lobjId); elog(ERROR, "inv_open: large object %u not found", lobjId);
@ -145,6 +151,9 @@ inv_open(Oid lobjId, int flags)
void void
inv_close(LargeObjectDesc *obj_desc) inv_close(LargeObjectDesc *obj_desc)
{ {
if (!IsTransactionBlock())
elog(ERROR, "inv_close: Not in transaction. BLOBs should be used inside transaction.");
Assert(PointerIsValid(obj_desc)); Assert(PointerIsValid(obj_desc));
if (obj_desc->flags & IFS_WRLOCK) if (obj_desc->flags & IFS_WRLOCK)
@ -164,6 +173,9 @@ inv_close(LargeObjectDesc *obj_desc)
int int
inv_drop(Oid lobjId) inv_drop(Oid lobjId)
{ {
if (!IsTransactionBlock())
elog(ERROR, "inv_drop: Not in transaction. BLOBs should be used inside transaction.");
LargeObjectDrop(lobjId); LargeObjectDrop(lobjId);
/* /*
@ -248,6 +260,9 @@ inv_getsize(LargeObjectDesc *obj_desc)
int int
inv_seek(LargeObjectDesc *obj_desc, int offset, int whence) inv_seek(LargeObjectDesc *obj_desc, int offset, int whence)
{ {
if (!IsTransactionBlock())
elog(ERROR, "inv_seek: Not in transaction. BLOBs should be used inside transaction.");
Assert(PointerIsValid(obj_desc)); Assert(PointerIsValid(obj_desc));
switch (whence) switch (whence)
@ -280,6 +295,9 @@ inv_seek(LargeObjectDesc *obj_desc, int offset, int whence)
int int
inv_tell(LargeObjectDesc *obj_desc) inv_tell(LargeObjectDesc *obj_desc)
{ {
if (!IsTransactionBlock())
elog(ERROR, "inv_tell: Not in transaction. BLOBs should be used inside transaction.");
Assert(PointerIsValid(obj_desc)); Assert(PointerIsValid(obj_desc));
return obj_desc->offset; return obj_desc->offset;
@ -303,6 +321,9 @@ inv_read(LargeObjectDesc *obj_desc, char *buf, int nbytes)
bytea *datafield; bytea *datafield;
bool pfreeit; bool pfreeit;
if (!IsTransactionBlock())
elog(ERROR, "inv_read: Not in transaction. BLOBs should be used inside transaction.");
Assert(PointerIsValid(obj_desc)); Assert(PointerIsValid(obj_desc));
Assert(buf != NULL); Assert(buf != NULL);
@ -415,6 +436,9 @@ inv_write(LargeObjectDesc *obj_desc, char *buf, int nbytes)
bool write_indices; bool write_indices;
Relation idescs[Num_pg_largeobject_indices]; Relation idescs[Num_pg_largeobject_indices];
if (!IsTransactionBlock())
elog(ERROR, "inv_write: Not in transaction. BLOBs should be used inside transaction.");
Assert(PointerIsValid(obj_desc)); Assert(PointerIsValid(obj_desc));
Assert(buf != NULL); Assert(buf != NULL);