mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Paranoia about possible values of errno after a shmget/semget failure.

Browse Source 
In theory we should always get EEXIST if there's a key collision, but
if the kernel code tests error conditions in a weird order, perhaps
EACCES or EIDRM could occur too.
This commit is contained in:
Tom Lane 2000-12-30 01:20:55 +00:00
parent 2153d1c106
commit c23851bbe0
1 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/backend/storage/ipc/ipc.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/storage/ipc/ipc.c,v 1.57 2000/12/11 00:49:52 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/storage/ipc/ipc.c,v 1.58 2000/12/30 01:20:55 tgl Exp $
* *
* NOTES * NOTES
* *
@ -272,9 +272,14 @@ InternalIpcSemaphoreCreate(IpcSemaphoreKey semKey,
/* /*
* Fail quietly if error indicates a collision with existing set. * Fail quietly if error indicates a collision with existing set.
* One would expect EEXIST, given that we said IPC_EXCL, but perhaps * One would expect EEXIST, given that we said IPC_EXCL, but perhaps
* we could get a permission violation instead? * we could get a permission violation instead? Also, EIDRM might
* occur if an old set is slated for destruction but not gone yet.
*/ */
if (errno == EEXIST || errno == EACCES) if (errno == EEXIST || errno == EACCES
#ifdef EIDRM
|| errno == EIDRM
#endif
)
return -1; return -1;
/* /*
* Else complain and abort * Else complain and abort
@ -516,9 +521,14 @@ InternalIpcMemoryCreate(IpcMemoryKey memKey, uint32 size, int permission)
/* /*
* Fail quietly if error indicates a collision with existing segment. * Fail quietly if error indicates a collision with existing segment.
* One would expect EEXIST, given that we said IPC_EXCL, but perhaps * One would expect EEXIST, given that we said IPC_EXCL, but perhaps
* we could get a permission violation instead? * we could get a permission violation instead? Also, EIDRM might
* occur if an old seg is slated for destruction but not gone yet.
*/ */
if (errno == EEXIST || errno == EACCES) if (errno == EEXIST || errno == EACCES
#ifdef EIDRM
|| errno == EIDRM
#endif
)
return NULL; return NULL;
/* /*
* Else complain and abort * Else complain and abort