mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid masking EOF (no-password-supplied) conditions in auth.c.

Browse Source 
CheckPWChallengeAuth() would return STATUS_ERROR if the user does not
exist or has no password assigned, even if the client disconnected
without responding to the password challenge (as libpq often will,
for example).  We should return STATUS_EOF in that case, and the
lower-level functions do, but this code level got it wrong since the
refactoring done in 7ac955b34.  This breaks the intent of not logging
anything for EOF cases (cf. comments in auth_failed()) and might
also confuse users of ClientAuthentication_hook.

Per report from Liu Lang.  Back-patch to all supported versions.

Discussion: https://postgr.es/m/b725238c-539d-cb09-2bff-b5e6cb2c069c@esgyn.cn
This commit is contained in:
Tom Lane 2024-01-03 17:40:38 -05:00
parent 54790f4b3f
commit c20f2aab6a
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/backend/libpq/auth.c
View File

@ -818,16 +818,15 @@ CheckPWChallengeAuth(Port *port, char **logdetail)
if (shadow_pass)
pfree(shadow_pass);
/*
* If get_role_password() returned error, return error, even if the
* authentication succeeded.
*/
if (!shadow_pass)
else
{
/*
* If get_role_password() returned error, authentication better not
* have succeeded.
*/
Assert(auth_result != STATUS_OK);
return STATUS_ERROR;
}
return auth_result;
}