From bea18b1c949145ba2ca79d4765dba3cc9494a480 Mon Sep 17 00:00:00 2001 From: Alexander Korotkov Date: Mon, 8 Jan 2024 15:00:42 +0200 Subject: [PATCH] Strengthen tests for 5ef34a8fc3 The test query in 5ef34a8fc3 is running over the empty emp1 table giving the same (empty) return both with and without the fix. Add one row to that table to make not just the test query plan, but also the test query result different. Reported-by: Richard Guo Bug: #18261 Discussion: https://postgr.es/m/CAMbWs49igjcszLgicb4D1N21_5iNDoxheJ7KFmAcs_z%3DLx6jhg%40mail.gmail.com --- src/test/regress/expected/join.out | 1 + src/test/regress/sql/join.sql | 1 + 2 files changed, 2 insertions(+) diff --git a/src/test/regress/expected/join.out b/src/test/regress/expected/join.out index 063396ab52..faad882a03 100644 --- a/src/test/regress/expected/join.out +++ b/src/test/regress/expected/join.out @@ -6881,6 +6881,7 @@ WHERE t1.id = emp1.id RETURNING emp1.id, emp1.code; (3 rows) -- Check that SJE does not mistakenly omit qual clauses (bug #18187) +insert into emp1 values (1, 1); explain (costs off) select 1 from emp1 full join (select * from emp1 t1 join diff --git a/src/test/regress/sql/join.sql b/src/test/regress/sql/join.sql index 5c420a7c6d..4f3c51b6eb 100644 --- a/src/test/regress/sql/join.sql +++ b/src/test/regress/sql/join.sql @@ -2623,6 +2623,7 @@ UPDATE emp1 SET code = t1.code + 1 FROM t1 WHERE t1.id = emp1.id RETURNING emp1.id, emp1.code; -- Check that SJE does not mistakenly omit qual clauses (bug #18187) +insert into emp1 values (1, 1); explain (costs off) select 1 from emp1 full join (select * from emp1 t1 join