mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix pg_verify_checksums on Windows.

Browse Source 
To verify the checksums, we open the file in text mode which doesn't work
on Windows as WIN32 treats Control-Z as EOF in files opened in text mode.
This leads to "short read of block .." error in some cases.

Fix it by opening the files in the binary mode.

Author: Amit Kapila
Reviewed-by: Magnus Hagander
Backpatch-through: 11
Discussion: https://postgr.es/m/CAA4eK1+LOnzod+h85FGmyjWzXKy-XV1FYwEyP-Tky2WpD5cxwA@mail.gmail.com
This commit is contained in:
Amit Kapila 2018-08-31 15:25:42 +05:30
parent 2e39f69b66
commit bb60f2cb6e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/bin/pg_verify_checksums/pg_verify_checksums.c
View File

@ -83,7 +83,7 @@ scan_file(char *fn, int segmentno)
int f; int f;
int blockno; int blockno;
f = open(fn, 0); f = open(fn, O_RDONLY | PG_BINARY);
if (f < 0) if (f < 0)
{ {
fprintf(stderr, _("%s: could not open file \"%s\": %s\n"), fprintf(stderr, _("%s: could not open file \"%s\": %s\n"),