mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid using sprintf() for a simple octal conversion in PQescapeByteaInternal.

Browse Source 
Improves performance, per suggestion from Rudolf Leitgeb (bug #4414).
The backend did this right already, but not libpq.
This commit is contained in:
Tom Lane 2008-09-10 17:01:07 +00:00
parent 3c221c3dae
commit bacf7b2086
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/interfaces/libpq/fe-exec.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/interfaces/libpq/fe-exec.c,v 1.196 2008/06/23 21:10:49 momjian Exp $ * $PostgreSQL: pgsql/src/interfaces/libpq/fe-exec.c,v 1.197 2008/09/10 17:01:07 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -2763,10 +2763,14 @@ PQescapeByteaInternal(PGconn *conn,
{ {
if (*vp < 0x20 || *vp > 0x7e) if (*vp < 0x20 || *vp > 0x7e)
{ {
int val = *vp;
if (!std_strings) if (!std_strings)
*rp++ = '\\'; *rp++ = '\\';
(void) sprintf((char *) rp, "\\%03o", *vp); *rp++ = '\\';
rp += 4; *rp++ = (val >> 6) + '0';
*rp++ = ((val >> 3) & 07) + '0';
*rp++ = (val & 07) + '0';
} }
else if (*vp == '\'') else if (*vp == '\'')
{ {