mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove configuration-dependent output from new inplace-inval test.

Browse Source 
Per buildfarm members prion and trilobite.  Back-patch to v12 (all
supported versions), like commit
0844b3968985447ed0a6937cfc8639e379da2fe6.

Strategy reviewed by Tom Lane.

Discussion: https://postgr.es/m/20240628051353.a0.nmisch@google.com
This commit is contained in:
Noah Misch 2024-06-28 09:33:40 -07:00
parent b48f275f18
commit b99414de90
2 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/test/isolation/expected/inplace-inval.out
View File

@ -1,6 +1,6 @@
Parsed test spec with 3 sessions Parsed test spec with 3 sessions
starting permutation: cachefill3 cir1 cic2 ddl3 read1 starting permutation: cachefill3 cir1 cic2 ddl3
step cachefill3: TABLE newly_indexed; step cachefill3: TABLE newly_indexed;
c c
- -
@ -9,14 +9,6 @@ c
step cir1: BEGIN; CREATE INDEX i1 ON newly_indexed (c); ROLLBACK; step cir1: BEGIN; CREATE INDEX i1 ON newly_indexed (c); ROLLBACK;
step cic2: CREATE INDEX i2 ON newly_indexed (c); step cic2: CREATE INDEX i2 ON newly_indexed (c);
step ddl3: ALTER TABLE newly_indexed ADD extra int; step ddl3: ALTER TABLE newly_indexed ADD extra int;
step read1:
SELECT relhasindex FROM pg_class WHERE oid = 'newly_indexed'::regclass;
relhasindex
-----------
f
(1 row)
starting permutation: cir1 cic2 ddl3 read1 starting permutation: cir1 cic2 ddl3 read1
step cir1: BEGIN; CREATE INDEX i1 ON newly_indexed (c); ROLLBACK; step cir1: BEGIN; CREATE INDEX i1 ON newly_indexed (c); ROLLBACK;

4
src/test/isolation/specs/inplace-inval.spec
View File

@ -27,12 +27,14 @@ step cachefill3 { TABLE newly_indexed; }
step ddl3 { ALTER TABLE newly_indexed ADD extra int; } step ddl3 { ALTER TABLE newly_indexed ADD extra int; }
# XXX shows an extant bug. Adding step read1 at the end would usually print
# relhasindex=f (not wanted). This does not reach the unwanted behavior under
# -DCATCACHE_FORCE_RELEASE and friends.
permutation permutation
cachefill3 # populates the pg_class row in the catcache cachefill3 # populates the pg_class row in the catcache
cir1 # sets relhasindex=true; rollback discards cache inval cir1 # sets relhasindex=true; rollback discards cache inval
cic2 # sees relhasindex=true, skips changing it (so no inval) cic2 # sees relhasindex=true, skips changing it (so no inval)
ddl3 # cached row as the oldtup of an update, losing relhasindex ddl3 # cached row as the oldtup of an update, losing relhasindex
read1 # observe damage XXX is an extant bug
# without cachefill3, no bug # without cachefill3, no bug
permutation cir1 cic2 ddl3 read1 permutation cir1 cic2 ddl3 read1