mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Silence -Wunused-result warning in contrib/pg_upgrade.

Browse Source 
This is just neatnik-ism, but since we do it for comparable code in elog.c,
we may as well do it here.
This commit is contained in:
Tom Lane 2012-09-05 14:36:47 -04:00
parent aa2b237ce5
commit b98fd52a55
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
contrib/pg_upgrade/util.c
View File

@ -81,10 +81,18 @@ pg_log(eLogType type, char *fmt,...)
/* fopen() on log_opts.internal might have failed, so check it */ /* fopen() on log_opts.internal might have failed, so check it */
if ((type != PG_VERBOSE || log_opts.verbose) && log_opts.internal != NULL) if ((type != PG_VERBOSE || log_opts.verbose) && log_opts.internal != NULL)
{ {
fwrite(message, strlen(message), 1, log_opts.internal); /*
* There's nothing much we can do about it if fwrite fails, but some
* platforms declare fwrite with warn_unused_result. Do a little
* dance with casting to void to shut up the compiler in such cases.
*/
size_t rc;
rc = fwrite(message, strlen(message), 1, log_opts.internal);
/* if we are using OVERWRITE_MESSAGE, add newline to log file */ /* if we are using OVERWRITE_MESSAGE, add newline to log file */
if (strchr(message, '\r') != NULL) if (strchr(message, '\r') != NULL)
fwrite("\n", 1, 1, log_opts.internal); rc = fwrite("\n", 1, 1, log_opts.internal);
(void) rc;
fflush(log_opts.internal); fflush(log_opts.internal);
} }