diff --git a/src/include/port/win32_port.h b/src/include/port/win32_port.h index a22867d295..296905bc6c 100644 --- a/src/include/port/win32_port.h +++ b/src/include/port/win32_port.h @@ -48,12 +48,21 @@ * significantly. WIN32_LEAN_AND_MEAN reduces that a bit. It'd be better to * remove the include of windows.h (as well as indirect inclusions of it) from * such a central place, but until then... + * + * To be able to include ntstatus.h tell windows.h to not declare NTSTATUS by + * temporarily defining UMDF_USING_NTSTATUS, otherwise we'll get warning about + * macro redefinitions, as windows.h also defines NTSTATUS (yuck). That in + * turn requires including ntstatus.h, winternl.h to get common symbols. */ #define WIN32_LEAN_AND_MEAN +#define UMDF_USING_NTSTATUS #include #include #include +#include +#include + #undef small #include #include diff --git a/src/include/port/win32ntdll.h b/src/include/port/win32ntdll.h index 34cebddd54..6d13a18b39 100644 --- a/src/include/port/win32ntdll.h +++ b/src/include/port/win32ntdll.h @@ -14,12 +14,6 @@ #ifndef WIN32NTDLL_H #define WIN32NTDLL_H -/* - * Because this includes NT headers that normally conflict with Win32 headers, - * any translation unit that includes it should #define UMDF_USING_NTSTATUS - * before including . - */ - #include #include diff --git a/src/port/open.c b/src/port/open.c index 8c09c7c1f7..fd4faf604e 100644 --- a/src/port/open.c +++ b/src/port/open.c @@ -13,8 +13,6 @@ #ifdef WIN32 -#define UMDF_USING_NTSTATUS - #ifndef FRONTEND #include "postgres.h" #else diff --git a/src/port/win32fdatasync.c b/src/port/win32fdatasync.c index 31d631c696..a5431615ab 100644 --- a/src/port/win32fdatasync.c +++ b/src/port/win32fdatasync.c @@ -11,8 +11,6 @@ *------------------------------------------------------------------------- */ -#define UMDF_USING_NTSTATUS - #ifdef FRONTEND #include "postgres_fe.h" #else diff --git a/src/port/win32ntdll.c b/src/port/win32ntdll.c index eb61407754..db3e5fa251 100644 --- a/src/port/win32ntdll.c +++ b/src/port/win32ntdll.c @@ -13,8 +13,6 @@ *------------------------------------------------------------------------- */ -#define UMDF_USING_NTSTATUS - #include "c.h" #include "port/win32ntdll.h" diff --git a/src/port/win32stat.c b/src/port/win32stat.c index 26443293d7..5f3d0d22ff 100644 --- a/src/port/win32stat.c +++ b/src/port/win32stat.c @@ -15,8 +15,6 @@ #ifdef WIN32 -#define UMDF_USING_NTSTATUS - #include "c.h" #include "port/win32ntdll.h"