From b8646012d560f3364b0076bb528866f869c3a61e Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Wed, 10 Sep 2008 19:16:22 +0000 Subject: [PATCH] Tweak newly added set_config_sourcefile() so that the target record isn't left corrupt if guc_strdup should fail. --- src/backend/utils/misc/guc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 4cc1ef3a94..a33cc0e41c 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -10,7 +10,7 @@ * Written by Peter Eisentraut . * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.471 2008/09/10 18:09:19 alvherre Exp $ + * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.472 2008/09/10 19:16:22 tgl Exp $ * *-------------------------------------------------------------------- */ @@ -5128,9 +5128,10 @@ set_config_sourcefile(const char *name, char *sourcefile, int sourceline) if (record == NULL) elog(ERROR, "unrecognized configuration parameter \"%s\"", name); + sourcefile = guc_strdup(elevel, sourcefile); if (record->sourcefile) free(record->sourcefile); - record->sourcefile = guc_strdup(elevel, sourcefile); + record->sourcefile = sourcefile; record->sourceline = sourceline; }