mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify WARNING messages from skipped vacuum/analyze on a table

Browse Source 
This will more easily accomodate adding new permissions for vacuum and
analyze.

Nathan Bossart following a suggestion from Kyotaro Horiguchi

Discussion: https://postgr.es/m/20220726.104712.912995710251150228.horikyota.ntt@gmail.com
This commit is contained in:
Andrew Dunstan 2022-11-23 14:41:30 -05:00
parent 7b378237aa
commit b7a5ef17cf
3 changed files with 65 additions and 85 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/backend/commands/vacuum.c
View File

@ -579,18 +579,9 @@ vacuum_is_relation_owner(Oid relid, Form_pg_class reltuple, bits32 options)
if ((options & VACOPT_VACUUM) != 0) if ((options & VACOPT_VACUUM) != 0)
{ {
if (reltuple->relisshared) ereport(WARNING,
ereport(WARNING, (errmsg("permission denied to vacuum \"%s\", skipping it",
(errmsg("skipping \"%s\" --- only superuser can vacuum it", relname)));
relname)));
else if (reltuple->relnamespace == PG_CATALOG_NAMESPACE)
ereport(WARNING,
(errmsg("skipping \"%s\" --- only superuser or database owner can vacuum it",
relname)));
else
ereport(WARNING,
(errmsg("skipping \"%s\" --- only table or database owner can vacuum it",
relname)));
/* /*
* For VACUUM ANALYZE, both logs could show up, but just generate * For VACUUM ANALYZE, both logs could show up, but just generate
@ -601,20 +592,9 @@ vacuum_is_relation_owner(Oid relid, Form_pg_class reltuple, bits32 options)
} }
if ((options & VACOPT_ANALYZE) != 0) if ((options & VACOPT_ANALYZE) != 0)
{ ereport(WARNING,
if (reltuple->relisshared) (errmsg("permission denied to analyze \"%s\", skipping it",
ereport(WARNING, relname)));
(errmsg("skipping \"%s\" --- only superuser can analyze it",
relname)));
else if (reltuple->relnamespace == PG_CATALOG_NAMESPACE)
ereport(WARNING,
(errmsg("skipping \"%s\" --- only superuser or database owner can analyze it",
relname)));
else
ereport(WARNING,
(errmsg("skipping \"%s\" --- only table or database owner can analyze it",
relname)));
}
return false; return false;
} }

16
src/test/isolation/expected/vacuum-conflict.out
View File

@ -4,7 +4,7 @@ starting permutation: s1_begin s1_lock s2_auth s2_vacuum s1_commit s2_reset
step s1_begin: BEGIN; step s1_begin: BEGIN;
step s1_lock: LOCK vacuum_tab IN SHARE UPDATE EXCLUSIVE MODE; step s1_lock: LOCK vacuum_tab IN SHARE UPDATE EXCLUSIVE MODE;
step s2_auth: SET ROLE regress_vacuum_conflict; step s2_auth: SET ROLE regress_vacuum_conflict;
s2: WARNING: skipping "vacuum_tab" --- only table or database owner can vacuum it s2: WARNING: permission denied to vacuum "vacuum_tab", skipping it
step s2_vacuum: VACUUM vacuum_tab; step s2_vacuum: VACUUM vacuum_tab;
step s1_commit: COMMIT; step s1_commit: COMMIT;
step s2_reset: RESET ROLE; step s2_reset: RESET ROLE;
@ -12,7 +12,7 @@ step s2_reset: RESET ROLE;
starting permutation: s1_begin s2_auth s2_vacuum s1_lock s1_commit s2_reset starting permutation: s1_begin s2_auth s2_vacuum s1_lock s1_commit s2_reset
step s1_begin: BEGIN; step s1_begin: BEGIN;
step s2_auth: SET ROLE regress_vacuum_conflict; step s2_auth: SET ROLE regress_vacuum_conflict;
s2: WARNING: skipping "vacuum_tab" --- only table or database owner can vacuum it s2: WARNING: permission denied to vacuum "vacuum_tab", skipping it
step s2_vacuum: VACUUM vacuum_tab; step s2_vacuum: VACUUM vacuum_tab;
step s1_lock: LOCK vacuum_tab IN SHARE UPDATE EXCLUSIVE MODE; step s1_lock: LOCK vacuum_tab IN SHARE UPDATE EXCLUSIVE MODE;
step s1_commit: COMMIT; step s1_commit: COMMIT;
@ -22,14 +22,14 @@ starting permutation: s1_begin s2_auth s1_lock s2_vacuum s1_commit s2_reset
step s1_begin: BEGIN; step s1_begin: BEGIN;
step s2_auth: SET ROLE regress_vacuum_conflict; step s2_auth: SET ROLE regress_vacuum_conflict;
step s1_lock: LOCK vacuum_tab IN SHARE UPDATE EXCLUSIVE MODE; step s1_lock: LOCK vacuum_tab IN SHARE UPDATE EXCLUSIVE MODE;
s2: WARNING: skipping "vacuum_tab" --- only table or database owner can vacuum it s2: WARNING: permission denied to vacuum "vacuum_tab", skipping it
step s2_vacuum: VACUUM vacuum_tab; step s2_vacuum: VACUUM vacuum_tab;
step s1_commit: COMMIT; step s1_commit: COMMIT;
step s2_reset: RESET ROLE; step s2_reset: RESET ROLE;
starting permutation: s2_auth s2_vacuum s1_begin s1_lock s1_commit s2_reset starting permutation: s2_auth s2_vacuum s1_begin s1_lock s1_commit s2_reset
step s2_auth: SET ROLE regress_vacuum_conflict; step s2_auth: SET ROLE regress_vacuum_conflict;
s2: WARNING: skipping "vacuum_tab" --- only table or database owner can vacuum it s2: WARNING: permission denied to vacuum "vacuum_tab", skipping it
step s2_vacuum: VACUUM vacuum_tab; step s2_vacuum: VACUUM vacuum_tab;
step s1_begin: BEGIN; step s1_begin: BEGIN;
step s1_lock: LOCK vacuum_tab IN SHARE UPDATE EXCLUSIVE MODE; step s1_lock: LOCK vacuum_tab IN SHARE UPDATE EXCLUSIVE MODE;
@ -40,7 +40,7 @@ starting permutation: s1_begin s1_lock s2_auth s2_analyze s1_commit s2_reset
step s1_begin: BEGIN; step s1_begin: BEGIN;
step s1_lock: LOCK vacuum_tab IN SHARE UPDATE EXCLUSIVE MODE; step s1_lock: LOCK vacuum_tab IN SHARE UPDATE EXCLUSIVE MODE;
step s2_auth: SET ROLE regress_vacuum_conflict; step s2_auth: SET ROLE regress_vacuum_conflict;
s2: WARNING: skipping "vacuum_tab" --- only table or database owner can analyze it s2: WARNING: permission denied to analyze "vacuum_tab", skipping it
step s2_analyze: ANALYZE vacuum_tab; step s2_analyze: ANALYZE vacuum_tab;
step s1_commit: COMMIT; step s1_commit: COMMIT;
step s2_reset: RESET ROLE; step s2_reset: RESET ROLE;
@ -48,7 +48,7 @@ step s2_reset: RESET ROLE;
starting permutation: s1_begin s2_auth s2_analyze s1_lock s1_commit s2_reset starting permutation: s1_begin s2_auth s2_analyze s1_lock s1_commit s2_reset
step s1_begin: BEGIN; step s1_begin: BEGIN;
step s2_auth: SET ROLE regress_vacuum_conflict; step s2_auth: SET ROLE regress_vacuum_conflict;
s2: WARNING: skipping "vacuum_tab" --- only table or database owner can analyze it s2: WARNING: permission denied to analyze "vacuum_tab", skipping it
step s2_analyze: ANALYZE vacuum_tab; step s2_analyze: ANALYZE vacuum_tab;
step s1_lock: LOCK vacuum_tab IN SHARE UPDATE EXCLUSIVE MODE; step s1_lock: LOCK vacuum_tab IN SHARE UPDATE EXCLUSIVE MODE;
step s1_commit: COMMIT; step s1_commit: COMMIT;
@ -58,14 +58,14 @@ starting permutation: s1_begin s2_auth s1_lock s2_analyze s1_commit s2_reset
step s1_begin: BEGIN; step s1_begin: BEGIN;
step s2_auth: SET ROLE regress_vacuum_conflict; step s2_auth: SET ROLE regress_vacuum_conflict;
step s1_lock: LOCK vacuum_tab IN SHARE UPDATE EXCLUSIVE MODE; step s1_lock: LOCK vacuum_tab IN SHARE UPDATE EXCLUSIVE MODE;
s2: WARNING: skipping "vacuum_tab" --- only table or database owner can analyze it s2: WARNING: permission denied to analyze "vacuum_tab", skipping it
step s2_analyze: ANALYZE vacuum_tab; step s2_analyze: ANALYZE vacuum_tab;
step s1_commit: COMMIT; step s1_commit: COMMIT;
step s2_reset: RESET ROLE; step s2_reset: RESET ROLE;
starting permutation: s2_auth s2_analyze s1_begin s1_lock s1_commit s2_reset starting permutation: s2_auth s2_analyze s1_begin s1_lock s1_commit s2_reset
step s2_auth: SET ROLE regress_vacuum_conflict; step s2_auth: SET ROLE regress_vacuum_conflict;
s2: WARNING: skipping "vacuum_tab" --- only table or database owner can analyze it s2: WARNING: permission denied to analyze "vacuum_tab", skipping it
step s2_analyze: ANALYZE vacuum_tab; step s2_analyze: ANALYZE vacuum_tab;
step s1_begin: BEGIN; step s1_begin: BEGIN;
step s1_lock: LOCK vacuum_tab IN SHARE UPDATE EXCLUSIVE MODE; step s1_lock: LOCK vacuum_tab IN SHARE UPDATE EXCLUSIVE MODE;

102
src/test/regress/expected/vacuum.out
View File

@ -295,120 +295,120 @@ CREATE ROLE regress_vacuum;
SET ROLE regress_vacuum; SET ROLE regress_vacuum;
-- Simple table -- Simple table
VACUUM vacowned; VACUUM vacowned;
WARNING: skipping "vacowned" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned", skipping it
ANALYZE vacowned; ANALYZE vacowned;
WARNING: skipping "vacowned" --- only table or database owner can analyze it WARNING: permission denied to analyze "vacowned", skipping it
VACUUM (ANALYZE) vacowned; VACUUM (ANALYZE) vacowned;
WARNING: skipping "vacowned" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned", skipping it
-- Catalog -- Catalog
VACUUM pg_catalog.pg_class; VACUUM pg_catalog.pg_class;
WARNING: skipping "pg_class" --- only superuser or database owner can vacuum it WARNING: permission denied to vacuum "pg_class", skipping it
ANALYZE pg_catalog.pg_class; ANALYZE pg_catalog.pg_class;
WARNING: skipping "pg_class" --- only superuser or database owner can analyze it WARNING: permission denied to analyze "pg_class", skipping it
VACUUM (ANALYZE) pg_catalog.pg_class; VACUUM (ANALYZE) pg_catalog.pg_class;
WARNING: skipping "pg_class" --- only superuser or database owner can vacuum it WARNING: permission denied to vacuum "pg_class", skipping it
-- Shared catalog -- Shared catalog
VACUUM pg_catalog.pg_authid; VACUUM pg_catalog.pg_authid;
WARNING: skipping "pg_authid" --- only superuser can vacuum it WARNING: permission denied to vacuum "pg_authid", skipping it
ANALYZE pg_catalog.pg_authid; ANALYZE pg_catalog.pg_authid;
WARNING: skipping "pg_authid" --- only superuser can analyze it WARNING: permission denied to analyze "pg_authid", skipping it
VACUUM (ANALYZE) pg_catalog.pg_authid; VACUUM (ANALYZE) pg_catalog.pg_authid;
WARNING: skipping "pg_authid" --- only superuser can vacuum it WARNING: permission denied to vacuum "pg_authid", skipping it
-- Partitioned table and its partitions, nothing owned by other user. -- Partitioned table and its partitions, nothing owned by other user.
-- Relations are not listed in a single command to test ownership -- Relations are not listed in a single command to test ownership
-- independently. -- independently.
VACUUM vacowned_parted; VACUUM vacowned_parted;
WARNING: skipping "vacowned_parted" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_parted", skipping it
WARNING: skipping "vacowned_part1" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part1", skipping it
WARNING: skipping "vacowned_part2" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part2", skipping it
VACUUM vacowned_part1; VACUUM vacowned_part1;
WARNING: skipping "vacowned_part1" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part1", skipping it
VACUUM vacowned_part2; VACUUM vacowned_part2;
WARNING: skipping "vacowned_part2" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part2", skipping it
ANALYZE vacowned_parted; ANALYZE vacowned_parted;
WARNING: skipping "vacowned_parted" --- only table or database owner can analyze it WARNING: permission denied to analyze "vacowned_parted", skipping it
WARNING: skipping "vacowned_part1" --- only table or database owner can analyze it WARNING: permission denied to analyze "vacowned_part1", skipping it
WARNING: skipping "vacowned_part2" --- only table or database owner can analyze it WARNING: permission denied to analyze "vacowned_part2", skipping it
ANALYZE vacowned_part1; ANALYZE vacowned_part1;
WARNING: skipping "vacowned_part1" --- only table or database owner can analyze it WARNING: permission denied to analyze "vacowned_part1", skipping it
ANALYZE vacowned_part2; ANALYZE vacowned_part2;
WARNING: skipping "vacowned_part2" --- only table or database owner can analyze it WARNING: permission denied to analyze "vacowned_part2", skipping it
VACUUM (ANALYZE) vacowned_parted; VACUUM (ANALYZE) vacowned_parted;
WARNING: skipping "vacowned_parted" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_parted", skipping it
WARNING: skipping "vacowned_part1" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part1", skipping it
WARNING: skipping "vacowned_part2" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part2", skipping it
VACUUM (ANALYZE) vacowned_part1; VACUUM (ANALYZE) vacowned_part1;
WARNING: skipping "vacowned_part1" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part1", skipping it
VACUUM (ANALYZE) vacowned_part2; VACUUM (ANALYZE) vacowned_part2;
WARNING: skipping "vacowned_part2" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part2", skipping it
RESET ROLE; RESET ROLE;
-- Partitioned table and one partition owned by other user. -- Partitioned table and one partition owned by other user.
ALTER TABLE vacowned_parted OWNER TO regress_vacuum; ALTER TABLE vacowned_parted OWNER TO regress_vacuum;
ALTER TABLE vacowned_part1 OWNER TO regress_vacuum; ALTER TABLE vacowned_part1 OWNER TO regress_vacuum;
SET ROLE regress_vacuum; SET ROLE regress_vacuum;
VACUUM vacowned_parted; VACUUM vacowned_parted;
WARNING: skipping "vacowned_part2" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part2", skipping it
VACUUM vacowned_part1; VACUUM vacowned_part1;
VACUUM vacowned_part2; VACUUM vacowned_part2;
WARNING: skipping "vacowned_part2" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part2", skipping it
ANALYZE vacowned_parted; ANALYZE vacowned_parted;
WARNING: skipping "vacowned_part2" --- only table or database owner can analyze it WARNING: permission denied to analyze "vacowned_part2", skipping it
ANALYZE vacowned_part1; ANALYZE vacowned_part1;
ANALYZE vacowned_part2; ANALYZE vacowned_part2;
WARNING: skipping "vacowned_part2" --- only table or database owner can analyze it WARNING: permission denied to analyze "vacowned_part2", skipping it
VACUUM (ANALYZE) vacowned_parted; VACUUM (ANALYZE) vacowned_parted;
WARNING: skipping "vacowned_part2" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part2", skipping it
VACUUM (ANALYZE) vacowned_part1; VACUUM (ANALYZE) vacowned_part1;
VACUUM (ANALYZE) vacowned_part2; VACUUM (ANALYZE) vacowned_part2;
WARNING: skipping "vacowned_part2" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part2", skipping it
RESET ROLE; RESET ROLE;
-- Only one partition owned by other user. -- Only one partition owned by other user.
ALTER TABLE vacowned_parted OWNER TO CURRENT_USER; ALTER TABLE vacowned_parted OWNER TO CURRENT_USER;
SET ROLE regress_vacuum; SET ROLE regress_vacuum;
VACUUM vacowned_parted; VACUUM vacowned_parted;
WARNING: skipping "vacowned_parted" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_parted", skipping it
WARNING: skipping "vacowned_part2" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part2", skipping it
VACUUM vacowned_part1; VACUUM vacowned_part1;
VACUUM vacowned_part2; VACUUM vacowned_part2;
WARNING: skipping "vacowned_part2" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part2", skipping it
ANALYZE vacowned_parted; ANALYZE vacowned_parted;
WARNING: skipping "vacowned_parted" --- only table or database owner can analyze it WARNING: permission denied to analyze "vacowned_parted", skipping it
WARNING: skipping "vacowned_part2" --- only table or database owner can analyze it WARNING: permission denied to analyze "vacowned_part2", skipping it
ANALYZE vacowned_part1; ANALYZE vacowned_part1;
ANALYZE vacowned_part2; ANALYZE vacowned_part2;
WARNING: skipping "vacowned_part2" --- only table or database owner can analyze it WARNING: permission denied to analyze "vacowned_part2", skipping it
VACUUM (ANALYZE) vacowned_parted; VACUUM (ANALYZE) vacowned_parted;
WARNING: skipping "vacowned_parted" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_parted", skipping it
WARNING: skipping "vacowned_part2" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part2", skipping it
VACUUM (ANALYZE) vacowned_part1; VACUUM (ANALYZE) vacowned_part1;
VACUUM (ANALYZE) vacowned_part2; VACUUM (ANALYZE) vacowned_part2;
WARNING: skipping "vacowned_part2" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part2", skipping it
RESET ROLE; RESET ROLE;
-- Only partitioned table owned by other user. -- Only partitioned table owned by other user.
ALTER TABLE vacowned_parted OWNER TO regress_vacuum; ALTER TABLE vacowned_parted OWNER TO regress_vacuum;
ALTER TABLE vacowned_part1 OWNER TO CURRENT_USER; ALTER TABLE vacowned_part1 OWNER TO CURRENT_USER;
SET ROLE regress_vacuum; SET ROLE regress_vacuum;
VACUUM vacowned_parted; VACUUM vacowned_parted;
WARNING: skipping "vacowned_part1" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part1", skipping it
WARNING: skipping "vacowned_part2" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part2", skipping it
VACUUM vacowned_part1; VACUUM vacowned_part1;
WARNING: skipping "vacowned_part1" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part1", skipping it
VACUUM vacowned_part2; VACUUM vacowned_part2;
WARNING: skipping "vacowned_part2" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part2", skipping it
ANALYZE vacowned_parted; ANALYZE vacowned_parted;
WARNING: skipping "vacowned_part1" --- only table or database owner can analyze it WARNING: permission denied to analyze "vacowned_part1", skipping it
WARNING: skipping "vacowned_part2" --- only table or database owner can analyze it WARNING: permission denied to analyze "vacowned_part2", skipping it
ANALYZE vacowned_part1; ANALYZE vacowned_part1;
WARNING: skipping "vacowned_part1" --- only table or database owner can analyze it WARNING: permission denied to analyze "vacowned_part1", skipping it
ANALYZE vacowned_part2; ANALYZE vacowned_part2;
WARNING: skipping "vacowned_part2" --- only table or database owner can analyze it WARNING: permission denied to analyze "vacowned_part2", skipping it
VACUUM (ANALYZE) vacowned_parted; VACUUM (ANALYZE) vacowned_parted;
WARNING: skipping "vacowned_part1" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part1", skipping it
WARNING: skipping "vacowned_part2" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part2", skipping it
VACUUM (ANALYZE) vacowned_part1; VACUUM (ANALYZE) vacowned_part1;
WARNING: skipping "vacowned_part1" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part1", skipping it
VACUUM (ANALYZE) vacowned_part2; VACUUM (ANALYZE) vacowned_part2;
WARNING: skipping "vacowned_part2" --- only table or database owner can vacuum it WARNING: permission denied to vacuum "vacowned_part2", skipping it
RESET ROLE; RESET ROLE;
DROP TABLE vacowned; DROP TABLE vacowned;
DROP TABLE vacowned_parted; DROP TABLE vacowned_parted;