Improve commentary in match_pathkeys_to_index().
For a little while there I thought match_pathkeys_to_index() was broken because it wasn't trying to match index columns to pathkeys in order. Actually that's correct, because GiST can support ordering operators on any random collection of index columns, but it sure needs a comment.
This commit is contained in:
parent
dd4134ea56
commit
b67ad046e6
@ -2174,6 +2174,13 @@ match_pathkeys_to_index(IndexOptInfo *index, List *pathkeys,
|
||||
if (!bms_equal(member->em_relids, index->rel->relids))
|
||||
continue;
|
||||
|
||||
/*
|
||||
* We allow any column of the index to match each pathkey; they
|
||||
* don't have to match left-to-right as you might expect. This
|
||||
* is correct for GiST, which is the sole existing AM supporting
|
||||
* amcanorderbyop. We might need different logic in future for
|
||||
* other implementations.
|
||||
*/
|
||||
for (indexcol = 0; indexcol < index->ncolumns; indexcol++)
|
||||
{
|
||||
Expr *expr;
|
||||
|
Loading…
x
Reference in New Issue
Block a user