mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix missing invalidations for search_path cache.

Browse Source 
Reported-by: Noah Misch
Discussion: https://postgr.es/m/20240630223047.1f.nmisch@google.com
Backpatch-through: 17
This commit is contained in:
Jeff Davis 2024-07-09 11:27:17 -07:00
parent e7192486dd
commit b3bd18294e
1 changed files with 21 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/backend/catalog/namespace.c
View File

@ -230,7 +230,7 @@ static void AccessTempTableNamespace(bool force);
static void InitTempTableNamespace(void); static void InitTempTableNamespace(void);
static void RemoveTempRelations(Oid tempNamespaceId); static void RemoveTempRelations(Oid tempNamespaceId);
static void RemoveTempRelationsCallback(int code, Datum arg); static void RemoveTempRelationsCallback(int code, Datum arg);
static void NamespaceCallback(Datum arg, int cacheid, uint32 hashvalue); static void InvalidationCallback(Datum arg, int cacheid, uint32 hashvalue);
static bool MatchNamedCall(HeapTuple proctup, int nargs, List *argnames, static bool MatchNamedCall(HeapTuple proctup, int nargs, List *argnames,
bool include_out_arguments, int pronargs, bool include_out_arguments, int pronargs,
int **argnumbers); int **argnumbers);
@ -4749,15 +4749,29 @@ InitializeSearchPath(void)
/* /*
* In normal mode, arrange for a callback on any syscache invalidation * In normal mode, arrange for a callback on any syscache invalidation
* of pg_namespace or pg_authid rows. (Changing a role name may affect * that will affect the search_path cache.
* the meaning of the special string $user.)
*/ */
/* namespace name or ACLs may have changed */
CacheRegisterSyscacheCallback(NAMESPACEOID, CacheRegisterSyscacheCallback(NAMESPACEOID,
NamespaceCallback, InvalidationCallback,
(Datum) 0); (Datum) 0);
/* role name may affect the meaning of "$user" */
CacheRegisterSyscacheCallback(AUTHOID, CacheRegisterSyscacheCallback(AUTHOID,
NamespaceCallback, InvalidationCallback,
(Datum) 0); (Datum) 0);
/* role membership may affect ACLs */
CacheRegisterSyscacheCallback(AUTHMEMROLEMEM,
InvalidationCallback,
(Datum) 0);
/* database owner may affect ACLs */
CacheRegisterSyscacheCallback(DATABASEOID,
InvalidationCallback,
(Datum) 0);
/* Force search path to be recomputed on next use */ /* Force search path to be recomputed on next use */
baseSearchPathValid = false; baseSearchPathValid = false;
searchPathCacheValid = false; searchPathCacheValid = false;
@ -4765,11 +4779,11 @@ InitializeSearchPath(void)
} }
/* /*
* NamespaceCallback * InvalidationCallback
* Syscache inval callback function * Syscache inval callback function
*/ */
static void static void
NamespaceCallback(Datum arg, int cacheid, uint32 hashvalue) InvalidationCallback(Datum arg, int cacheid, uint32 hashvalue)
{ {
/* /*
* Force search path to be recomputed on next use, also invalidating the * Force search path to be recomputed on next use, also invalidating the