mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove surplus call to table_finish_bulk_insert

Browse Source 
4de60244e added the call to table_finish_bulk_insert to the
CopyMultiInsertBufferCleanup function.  We use a CopyMultiInsertBuffer even
for non-partitioned tables, so having the cleanup do that meant we would
call table_finsh_bulk_insert twice when performing COPY FROM with
a non-partitioned table.

Here we can just remove the direct call in CopyFrom and let
CopyMultiInsertBufferCleanup handle the call instead.
This commit is contained in:
David Rowley 2019-07-02 03:07:15 +12:00
parent 4de60244e2
commit b2d69806d8
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/commands/copy.c
View File

@ -3369,8 +3369,6 @@ CopyFrom(CopyState cstate)
if (insertMethod != CIM_SINGLE) if (insertMethod != CIM_SINGLE)
{ {
table_finish_bulk_insert(cstate->rel, ti_options);
/* Tear down the multi-insert buffer data */ /* Tear down the multi-insert buffer data */
CopyMultiInsertInfoCleanup(&multiInsertInfo); CopyMultiInsertInfoCleanup(&multiInsertInfo);
} }