mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Allow -2147483648 to be treated as an INT4 rather than INT8 constant.

Browse Source 
Per discussion with Paul Edwards.
This commit is contained in:
Tom Lane 2005-04-23 18:35:12 +00:00
parent d79eeef38b
commit b1faf3624b
1 changed files with 25 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/backend/parser/parse_node.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/parser/parse_node.c,v 1.87 2004/12/31 22:00:27 pgsql Exp $ * $PostgreSQL: pgsql/src/backend/parser/parse_node.c,v 1.88 2005/04/23 18:35:12 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -276,9 +276,9 @@ transformArraySubscripts(ParseState *pstate,
* Explicit "NULL" constants are also typed as UNKNOWN. * Explicit "NULL" constants are also typed as UNKNOWN.
* *
* For integers and floats we produce int4, int8, or numeric depending * For integers and floats we produce int4, int8, or numeric depending
* on the value of the number. XXX This should include int2 as well, * on the value of the number. XXX We should produce int2 as well,
* but additional cleanup is needed before we can do that; else cases * but additional cleanup is needed before we can do that; there are
* like "WHERE int4var = 42" will fail to be indexable. * too many examples that fail if we try.
*/ */
Const * Const *
make_const(Value *value) make_const(Value *value)
@ -304,11 +304,28 @@ make_const(Value *value)
/* could be an oversize integer as well as a float ... */ /* could be an oversize integer as well as a float ... */
if (scanint8(strVal(value), true, &val64)) if (scanint8(strVal(value), true, &val64))
{ {
val = Int64GetDatum(val64); /*
* It might actually fit in int32. Probably only INT_MIN can
* occur, but we'll code the test generally just to be sure.
*/
int32 val32 = (int32) val64;
typeid = INT8OID; if (val64 == (int64) val32)
typelen = sizeof(int64); {
typebyval = false; /* XXX might change someday */ val = Int32GetDatum(val32);
typeid = INT4OID;
typelen = sizeof(int32);
typebyval = true;
}
else
{
val = Int64GetDatum(val64);
typeid = INT8OID;
typelen = sizeof(int64);
typebyval = false; /* XXX might change someday */
}
} }
else else
{ {