mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Reject missing database name in pg_regress and cohorts.

Browse Source 
Writing "pg_regress --dbname= ..." led to a crash, because
we weren't expecting there to be no database name supplied.
It doesn't seem like a great idea to run regression tests
in whatever is the user's default database; so rather than
supporting this case let's explicitly reject it.

Per report from Xing Guo.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/CACpMh+A8cRvtvtOWVAZsCM1DU81GK4DL26R83y6ugZ1osV=ifA@mail.gmail.com
This commit is contained in:
Tom Lane 2022-11-30 13:01:41 -05:00
parent 4df5462f34
commit ae9939020d
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/test/regress/pg_regress.c
View File

@ -2277,6 +2277,17 @@ regression_main(int argc, char *argv[], init_function ifunc, test_function tfunc
optind++; optind++;
} }
/*
* We must have a database to run the tests in; either a default name, or
* one supplied by the --dbname switch.
*/
if (!(dblist && dblist->str && dblist->str[0]))
{
fprintf(stderr, _("%s: no database name was specified\n"),
progname);
exit(2);
}
if (config_auth_datadir) if (config_auth_datadir)
{ {
#ifdef ENABLE_SSPI #ifdef ENABLE_SSPI