mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix small query-lifespan memory leak in bulk updates.

Browse Source 
When there is an identifiable REPLICA IDENTITY index on the target table,
heap_update leaks the id_attrs bitmapset.  That's not many bytes, but it
adds up over enough rows, since the code typically runs in a query-lifespan
context.  Bug introduced in commit e55704d8b, which did a rather poor job
of cloning the existing use-pattern for RelationGetIndexAttrBitmap().

Per bug #14293 from Zhou Digoal.  Back-patch to 9.4 where the bug was
introduced.

Report: <20160824114320.15676.45171@wrigleys.postgresql.org>
This commit is contained in:
Tom Lane 2016-08-24 22:20:01 -04:00
parent ca9cb940d2
commit ae4760d667
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/access/heap/heapam.c
View File

@ -3802,6 +3802,7 @@ l2:
ReleaseBuffer(vmbuffer); ReleaseBuffer(vmbuffer);
bms_free(hot_attrs); bms_free(hot_attrs);
bms_free(key_attrs); bms_free(key_attrs);
bms_free(id_attrs);
return result; return result;
} }
@ -4268,6 +4269,7 @@ l2:
bms_free(hot_attrs); bms_free(hot_attrs);
bms_free(key_attrs); bms_free(key_attrs);
bms_free(id_attrs);
return HeapTupleMayBeUpdated; return HeapTupleMayBeUpdated;
} }