mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove some recently-added pg_dump test cases.

Browse Source 
Commit d2d35479796c3510e249d6fc72adbd5df918efbf included a pretty
extensive set of test cases, and some of them don't work on all
of our Windows machines. This happens because IPC::Run expands
its arguments as shell globs on a few machines, but doesn't on most
of the buildfarm. It might be good to fix that problem systematically
somehow, but in the meantime, there are enough test cases for this
commit that it seems OK to just remove the ones that are failing.

Discussion: http://postgr.es/m/3a190754-b2b0-d02b-dcfd-4ec1610ffbcb@dunslane.net
Discussion: http://postgr.es/m/CA+TgmoYRGUcFBy6VgN0+Pn4f6Wv=2H0HZLuPHqSy6VC8Ba7vdg@mail.gmail.com
This commit is contained in:
Robert Haas 2022-04-22 16:16:52 -04:00
parent 826be1ffb2
commit a66e722cc1
1 changed files with 0 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/bin/pg_dump/t/002_pg_dump.pl
View File

@ -3982,18 +3982,6 @@ $node->command_fails_like(
'pg_dumpall: option --exclude-database rejects multipart pattern "."'
);
$node->command_fails_like(
[ 'pg_dumpall', '--exclude-database', '.*' ],
qr/pg_dumpall: error: improper qualified name \(too many dotted names\): \.\*/,
'pg_dumpall: option --exclude-database rejects multipart pattern ".*"'
);
$node->command_fails_like(
[ 'pg_dumpall', '--exclude-database', '*.*' ],
qr/pg_dumpall: error: improper qualified name \(too many dotted names\): \*\.\*/,
'pg_dumpall: option --exclude-database rejects multipart pattern "*.*"'
);
$node->command_fails_like(
[ 'pg_dumpall', '--exclude-database', 'myhost.mydb' ],
qr/pg_dumpall: error: improper qualified name \(too many dotted names\): myhost\.mydb/,
@ -4008,12 +3996,6 @@ $node->command_ok(
'pg_dumpall: option --exclude-database handles database names with embedded dots'
);
$node->command_ok(
[ 'pg_dumpall', '--exclude-database', '??*' ],
'pg_dumpall: option --exclude-database handles database name patterns'
);
#########################################
# Test invalid multipart schema names
@ -4041,24 +4023,12 @@ $node->command_fails_like(
'pg_dump: option --schema rejects cross-database multipart schema names with embedded dots'
);
$node->command_fails_like(
[ 'pg_dump', '--schema', '.*' ],
qr/pg_dump: error: cross-database references are not implemented: \.\*/,
'pg_dump: option --schema rejects degenerate two-part schema name: ".*"'
);
$node->command_fails_like(
[ 'pg_dump', '--schema', '..' ],
qr/pg_dump: error: improper qualified name \(too many dotted names\): \.\./,
'pg_dump: option --schema rejects degenerate three-part schema name: ".."'
);
$node->command_fails_like(
[ 'pg_dump', '--schema', '.*.*' ],
qr/pg_dump: error: improper qualified name \(too many dotted names\): \.\*\.\*/,
'pg_dump: option --schema rejects degenerate three-part schema pattern: ".*.*"'
);
#########################################
# Test invalid multipart relation names