mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pg_dump: label INDEX ATTACH ArchiveEntries with an owner.

Browse Source 
Although a partitioned index's attachment to its parent doesn't
have separate ownership, the ArchiveEntry for it needs to be
marked with an owner anyway, to ensure that the ALTER command
is run by the appropriate role when restoring with
--use-set-session-authorization.  Without this, the ALTER will
be run by the role that started the restore session, which will
usually work but it's formally the wrong thing.

Back-patch to v11 where this type of ArchiveEntry was added.
In HEAD, add equivalent commentary to the just-added TABLE ATTACH
case, which I'd made do the right thing already.

Discussion: https://postgr.es/m/1094034.1610418498@sss.pgh.pa.us
This commit is contained in:
Tom Lane 2021-01-12 13:37:38 -05:00
parent 57404fe9e1
commit 9f15188a1b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/bin/pg_dump/pg_dump.c
View File

@ -16532,7 +16532,7 @@ dumpIndexAttach(Archive *fout, IndexAttachInfo *attachinfo)
attachinfo->dobj.name,
attachinfo->dobj.namespace->dobj.name,
NULL,
"",
attachinfo->parentIdx->indextable->rolname,
false, "INDEX ATTACH", SECTION_POST_DATA,
q->data, "", NULL,
NULL, 0,