mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gistendscan() forgot to free so->giststate.

Browse Source 
This oversight led to a massive memory leak --- upwards of 10KB per tuple
--- during creation-time verification of an exclusion constraint based on a
GIST index.  In most other scenarios it'd just be a leak of 10KB that would
be recovered at end of query, so not too significant; though perhaps the
leak would be noticeable in a situation where a GIST index was being used
in a nestloop inner indexscan.  In any case, it's a real leak of long
standing, so patch all supported branches.  Per report from Harald Fuchs.
This commit is contained in:
Tom Lane 2011-09-16 04:28:07 -04:00
parent 5d68fe14fc
commit 9bc6daae09
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/access/gist/gistscan.c
View File

@ -135,12 +135,15 @@ gistendscan(PG_FUNCTION_ARGS)
{ {
gistfreestack(so->stack); gistfreestack(so->stack);
if (so->giststate != NULL) if (so->giststate != NULL)
{
freeGISTstate(so->giststate); freeGISTstate(so->giststate);
pfree(so->giststate);
}
/* drop pins on buffers -- we aren't holding any locks */ /* drop pins on buffers -- we aren't holding any locks */
if (BufferIsValid(so->curbuf)) if (BufferIsValid(so->curbuf))
ReleaseBuffer(so->curbuf); ReleaseBuffer(so->curbuf);
MemoryContextDelete(so->tempCxt); MemoryContextDelete(so->tempCxt);
pfree(scan->opaque); pfree(so);
} }
PG_RETURN_VOID(); PG_RETURN_VOID();