mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add missing NULL check when building Result Cache paths

Browse Source 
Code added in 9e215378d to disable building of Result Cache paths when
not all join conditions are part of the parameterization of a unique
join failed to first check if the inner path's param_info was set before
checking the param_info's ppi_clauses.

Add a check for NULL values here and just bail on trying to build the
path if param_info is NULL. lateral_vars are not considered when
deciding if the join is unique, so we're not missing out on doing the
optimization when there are lateral_vars and no param_info.

Reported-by: Coverity, via Tom Lane
Discussion: https://postgr.es/m/457998.1621779290@sss.pgh.pa.us
This commit is contained in:
David Rowley 2021-05-24 12:37:11 +12:00
parent f5024d8d7b
commit 99c5852e20
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/optimizer/path/joinpath.c
View File

@ -530,8 +530,9 @@ get_resultcache_path(PlannerInfo *root, RelOptInfo *innerrel,
* considering doing that? * considering doing that?
*/ */
if (extra->inner_unique && if (extra->inner_unique &&
list_length(inner_path->param_info->ppi_clauses) < (inner_path->param_info == NULL ||
list_length(extra->restrictlist)) list_length(inner_path->param_info->ppi_clauses) <
list_length(extra->restrictlist)))
return NULL; return NULL;
/* /*