mirrors
/
postgres
mirror of https://github.com/postgres/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove dry-run mode from isolationtester 

The original purpose of the dry-run mode is to be able to print all the
possible permutations from a spec file, but it has become less useful
since isolation tests has improved regarding deadlock detection as one
step not wanted by the author could block indefinitely now (originally
the step blocked would have been detected rather quickly).  Per
discussion, let's remove it.

Author: Michael Paquier
Reviewed-by: Asim Praveen, Melanie Plageman
Discussion: https://postgr.es/m/20190819080820.GG18166@paquier.xyz
This commit is contained in:
Michael Paquier 2019-08-24 11:35:43 +09:00
parent 292ae8af79
commit 9903338b5e
1 changed files with 1 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/test/isolation/isolationtester.c
View File

@ -31,9 +31,6 @@ static int *backend_pids = NULL;
static const char **backend_pid_strs = NULL; static const char **backend_pid_strs = NULL;
static int nconns = 0; static int nconns = 0;
/* In dry run only output permutations to be run by the tester. */
static int dry_run = false;
static void run_testspec(TestSpec *testspec); static void run_testspec(TestSpec *testspec);
static void run_all_permutations(TestSpec *testspec); static void run_all_permutations(TestSpec *testspec);
static void run_all_permutations_recurse(TestSpec *testspec, int nsteps, static void run_all_permutations_recurse(TestSpec *testspec, int nsteps,
@ -76,13 +73,10 @@ main(int argc, char **argv)
int nallsteps; int nallsteps;
Step **allsteps; Step **allsteps;
while ((opt = getopt(argc, argv, "nV")) != -1) while ((opt = getopt(argc, argv, "V")) != -1)
{ {
switch (opt) switch (opt)
{ {
case 'n':
dry_run = true;
break;
case 'V': case 'V':
puts("isolationtester (PostgreSQL) " PG_VERSION); puts("isolationtester (PostgreSQL) " PG_VERSION);
exit(0); exit(0);
@ -144,16 +138,6 @@ main(int argc, char **argv)
} }
} }
/*
* In dry-run mode, just print the permutations that would be run, and
* exit.
*/
if (dry_run)
{
run_testspec(testspec);
return 0;
}
printf("Parsed test spec with %d sessions\n", testspec->nsessions); printf("Parsed test spec with %d sessions\n", testspec->nsessions);
/* /*
@ -449,19 +433,6 @@ run_permutation(TestSpec *testspec, int nsteps, Step **steps)
Step **waiting; Step **waiting;
Step **errorstep; Step **errorstep;
/*
* In dry run mode, just display the permutation in the same format used
* by spec files, and return.
*/
if (dry_run)
{
printf("permutation");
for (i = 0; i < nsteps; i++)
printf(" \"%s\"", steps[i]->name);
printf("\n");
return;
}
waiting = pg_malloc(sizeof(Step *) * testspec->nsessions); waiting = pg_malloc(sizeof(Step *) * testspec->nsessions);
errorstep = pg_malloc(sizeof(Step *) * testspec->nsessions); errorstep = pg_malloc(sizeof(Step *) * testspec->nsessions);