mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve coding pattern in Parallel Append code.

Browse Source 
The create_append_path code didn't consider that list_concat will
modify it's first argument leading to inconsistent traversal of
resulting list.  In practice, it won't lead to any user-visible bug
but changing it for making the code behave consistently.

Reported-by: Tom Lane
Author: Tom Lane
Reviewed-by: Amit Khandekar and Amit Kapila
Discussion: https://postgr.es/m/32365.1528994120@sss.pgh.pa.us
This commit is contained in:
Amit Kapila 2018-06-22 08:43:36 +05:30
parent c7048977a7
commit 98d476a965
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/optimizer/util/pathnode.c
View File

@ -1274,7 +1274,7 @@ create_append_path(PlannerInfo *root,
pathnode->first_partial_path = list_length(subpaths); pathnode->first_partial_path = list_length(subpaths);
pathnode->subpaths = list_concat(subpaths, partial_subpaths); pathnode->subpaths = list_concat(subpaths, partial_subpaths);
foreach(l, subpaths) foreach(l, pathnode->subpaths)
{ {
Path *subpath = (Path *) lfirst(l); Path *subpath = (Path *) lfirst(l);