mirrors
/
postgres
mirror of https://github.com/postgres/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix an ancient oversight in change_varattnos_of_a_node: it neglected to update 

varoattno along with varattno.  This resulted in having Vars that were not
seen as equal(), causing inheritance of the "same" constraint from different
parent relations to fail.  An example is

create table pp1 (f1 int check (f1>0));
create table cc1 (f2 text, f3 int) inherits (pp1);
create table cc2(f4 float) inherits(pp1,cc1);

Backpatch as far as 7.4.  (The test case still fails in 7.4, for reasons
that I don't feel like investigating at the moment.)

This is a backpatch commit only.  The fix will be applied in HEAD as part
of the upcoming pg_constraint patch.
This commit is contained in:
Tom Lane 2008-05-09 22:37:56 +00:00
parent d42f212573
commit 98bf422625
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/commands/tablecmds.c
View File

@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.142.4.8 2008/04/24 20:18:23 tgl Exp $
* $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.142.4.9 2008/05/09 22:37:56 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@ -1062,7 +1062,7 @@ change_varattnos_walker(Node *node, const AttrNumber *newattno)
* such a node currently.
*/
Assert(newattno[var->varattno - 1] > 0);
var->varattno = newattno[var->varattno - 1];
var->varattno = var->varoattno = newattno[var->varattno - 1];
}
return false;
}