mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix random regression failure in test case "collate.icu.utf8"

Browse Source 
This is a fix similar to 2d7d67cc, where slight plan alteration can
cause a random failure of this regression test because of an incorect
tuple ordering, except that this one involves lookups of pg_type.
Similarly to the other case, add ORDER BY clauses to ensure the output
order.

The failure has been seen at least once on buildfarm member skink.

Reported-by: Thomas Munro
Discussion: https://postgr.es/m/CA+hUKGLjR9ZBvhXcr9b-NSBHPw9aRgbjyzGE+kqLsT4vwX+nkQ@mail.gmail.com
Backpatch-through: 12
This commit is contained in:
Michael Paquier 2019-08-14 13:37:48 +09:00
parent 68ef887842
commit 96e7e1bc08
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/test/regress/expected/collate.icu.utf8.out
View File

@ -1651,14 +1651,16 @@ SELECT relname FROM pg_class WHERE 'PG_CLASS'::text = relname COLLATE case_insen
pg_class pg_class
(1 row) (1 row)
SELECT typname FROM pg_type WHERE typname LIKE 'int_' AND typname <> 'INT2'::text COLLATE case_insensitive; SELECT typname FROM pg_type WHERE typname LIKE 'int_' AND typname <> 'INT2'::text
COLLATE case_insensitive ORDER BY typname;
typname typname
--------- ---------
int4 int4
int8 int8
(2 rows) (2 rows)
SELECT typname FROM pg_type WHERE typname LIKE 'int_' AND 'INT2'::text <> typname COLLATE case_insensitive;; SELECT typname FROM pg_type WHERE typname LIKE 'int_' AND 'INT2'::text <> typname
COLLATE case_insensitive ORDER BY typname;
typname typname
--------- ---------
int4 int4

6
src/test/regress/sql/collate.icu.utf8.sql
View File

@ -603,8 +603,10 @@ SELECT 'ὀδυσσεύς' = 'ὈΔΥΣΣΕΎΣ' COLLATE case_insensitive;
SELECT relname FROM pg_class WHERE relname = 'PG_CLASS'::text COLLATE case_insensitive; SELECT relname FROM pg_class WHERE relname = 'PG_CLASS'::text COLLATE case_insensitive;
SELECT relname FROM pg_class WHERE 'PG_CLASS'::text = relname COLLATE case_insensitive; SELECT relname FROM pg_class WHERE 'PG_CLASS'::text = relname COLLATE case_insensitive;
SELECT typname FROM pg_type WHERE typname LIKE 'int_' AND typname <> 'INT2'::text COLLATE case_insensitive; SELECT typname FROM pg_type WHERE typname LIKE 'int_' AND typname <> 'INT2'::text
SELECT typname FROM pg_type WHERE typname LIKE 'int_' AND 'INT2'::text <> typname COLLATE case_insensitive;; COLLATE case_insensitive ORDER BY typname;
SELECT typname FROM pg_type WHERE typname LIKE 'int_' AND 'INT2'::text <> typname
COLLATE case_insensitive ORDER BY typname;
-- test case adapted from subselect.sql -- test case adapted from subselect.sql
CREATE TEMP TABLE outer_text (f1 text COLLATE case_insensitive, f2 text); CREATE TEMP TABLE outer_text (f1 text COLLATE case_insensitive, f2 text);