mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid possible segfault in psql's tab completion.

Browse Source 
Fix oversight in bd1276a3c: the "words_after_create" stanza in
psql_completion() requires previous_words_count > 0, since it uses
prev_wd.  This condition was formerly assured by the if-else chain
above it, but no more.  If there were no previous words then we'd
dereference an uninitialized pointer, possibly causing a segfault.

Report and patch by Anthonin Bonnefoy.

Discussion: https://postgr.es/m/CAO6_XqrSRE7c_i+D7Hm07K3+6S0jTAmMr60RY41XzaA29Ae5uA@mail.gmail.com
This commit is contained in:
Tom Lane 2024-10-10 16:17:38 -04:00
parent fd64ed60b6
commit 95eb4cd4ff
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/bin/psql/tab-complete.in.c
View File

@ -2024,7 +2024,7 @@ psql_completion(const char *text, int start, int end)
* check if that was the previous word. If so, execute the query to get a * check if that was the previous word. If so, execute the query to get a
* list of them. * list of them.
*/ */
if (matches == NULL) if (matches == NULL && previous_words_count > 0)
{ {
const pgsql_thing_t *wac; const pgsql_thing_t *wac;