mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Adjust some more comments for WITH OIDS removal.

Browse Source 
I missed these in 578b229718e8f.

Author: Andres Freund
This commit is contained in:
Andres Freund 2019-01-21 09:05:51 -08:00
parent 8eb4a9312c
commit 93507e67c9
1 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/backend/access/heap/heapam.c
View File

@ -2451,11 +2451,10 @@ ReleaseBulkInsertStatePin(BulkInsertState bistate)
* The BulkInsertState object (if any; bistate can be NULL for default * The BulkInsertState object (if any; bistate can be NULL for default
* behavior) is also just passed through to RelationGetBufferForTuple. * behavior) is also just passed through to RelationGetBufferForTuple.
* *
* The return value is the OID assigned to the tuple (either here or by the * On return the header fields of *tup are updated to match the stored tuple;
* caller), or InvalidOid if no OID. The header fields of *tup are updated * in particular tup->t_self receives the actual TID where the tuple was
* to match the stored tuple; in particular tup->t_self receives the actual * stored. But note that any toasting of fields within the tuple data is NOT
* TID where the tuple was stored. But note that any toasting of fields * reflected into *tup.
* within the tuple data is NOT reflected into *tup.
*/ */
void void
heap_insert(Relation relation, HeapTuple tup, CommandId cid, heap_insert(Relation relation, HeapTuple tup, CommandId cid,
@ -2468,8 +2467,7 @@ heap_insert(Relation relation, HeapTuple tup, CommandId cid,
bool all_visible_cleared = false; bool all_visible_cleared = false;
/* /*
* Fill in tuple header fields, assign an OID, and toast the tuple if * Fill in tuple header fields and toast the tuple if necessary.
* necessary.
* *
* Note: below this point, heaptup is the data we actually intend to store * Note: below this point, heaptup is the data we actually intend to store
* into the relation; tup is the caller's original untoasted data. * into the relation; tup is the caller's original untoasted data.
@ -2635,10 +2633,9 @@ heap_insert(Relation relation, HeapTuple tup, CommandId cid,
/* /*
* Subroutine for heap_insert(). Prepares a tuple for insertion. This sets the * Subroutine for heap_insert(). Prepares a tuple for insertion. This sets the
* tuple header fields, assigns an OID, and toasts the tuple if necessary. * tuple header fields and toasts the tuple if necessary. Returns a toasted
* Returns a toasted version of the tuple if it was toasted, or the original * version of the tuple if it was toasted, or the original tuple if not. Note
* tuple if not. Note that in any case, the header fields are also set in * that in any case, the header fields are also set in the original tuple.
* the original tuple.
*/ */
static HeapTuple static HeapTuple
heap_prepare_insert(Relation relation, HeapTuple tup, TransactionId xid, heap_prepare_insert(Relation relation, HeapTuple tup, TransactionId xid,