mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Sync PG_VERSION file in CREATE DATABASE.

Browse Source 
An OS crash could leave PG_VERSION empty or missing.  The same symptom
appeared in a backup by block device snapshot, taken after the next
checkpoint and before the OS flushes the PG_VERSION blocks.  Device
snapshots are not a documented backup method, however.  Back-patch to
v15, where commit 9c08aea6a3090a396be334cc58c511edab05776a introduced
STRATEGY=WAL_LOG and made it the default.

Discussion: https://postgr.es/m/20240130195003.0a.nmisch@google.com
This commit is contained in:
Noah Misch 2024-02-01 13:44:19 -08:00
parent d493bed28f
commit 8fa4a1ac61
4 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
doc/src/sgml/monitoring.sgml
View File

@ -1519,6 +1519,11 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser
<entry><literal>TwophaseFileWrite</literal></entry> <entry><literal>TwophaseFileWrite</literal></entry>
<entry>Waiting for a write of a two phase state file.</entry> <entry>Waiting for a write of a two phase state file.</entry>
</row> </row>
<row>
<entry><literal>VersionFileSync</literal></entry>
<entry>Waiting for the version file to reach durable storage while
creating a database.</entry>
</row>
<row> <row>
<entry><literal>VersionFileWrite</literal></entry> <entry><literal>VersionFileWrite</literal></entry>
<entry>Waiting for the version file to be written while creating a database.</entry> <entry>Waiting for the version file to be written while creating a database.</entry>

8
src/backend/commands/dbcommands.c
View File

@ -507,6 +507,14 @@ CreateDirAndVersionFile(char *dbpath, Oid dbid, Oid tsid, bool isRedo)
} }
pgstat_report_wait_end(); pgstat_report_wait_end();
pgstat_report_wait_start(WAIT_EVENT_VERSION_FILE_SYNC);
if (pg_fsync(fd) != 0)
ereport(data_sync_elevel(ERROR),
(errcode_for_file_access(),
errmsg("could not fsync file \"%s\": %m", versionfile)));
fsync_fname(dbpath, true);
pgstat_report_wait_end();
/* Close the version file. */ /* Close the version file. */
CloseTransientFile(fd); CloseTransientFile(fd);

3
src/backend/utils/activity/wait_event.c
View File

@ -702,6 +702,9 @@ pgstat_get_wait_io(WaitEventIO w)
case WAIT_EVENT_TWOPHASE_FILE_WRITE: case WAIT_EVENT_TWOPHASE_FILE_WRITE:
event_name = "TwophaseFileWrite"; event_name = "TwophaseFileWrite";
break; break;
case WAIT_EVENT_VERSION_FILE_SYNC:
event_name = "VersionFileSync";
break;
case WAIT_EVENT_VERSION_FILE_WRITE: case WAIT_EVENT_VERSION_FILE_WRITE:
event_name = "VersionFileWrite"; event_name = "VersionFileWrite";
break; break;

3
src/include/utils/wait_event.h
View File

@ -229,7 +229,8 @@ typedef enum
WAIT_EVENT_WAL_READ, WAIT_EVENT_WAL_READ,
WAIT_EVENT_WAL_SYNC, WAIT_EVENT_WAL_SYNC,
WAIT_EVENT_WAL_SYNC_METHOD_ASSIGN, WAIT_EVENT_WAL_SYNC_METHOD_ASSIGN,
WAIT_EVENT_WAL_WRITE WAIT_EVENT_WAL_WRITE,
WAIT_EVENT_VERSION_FILE_SYNC
} WaitEventIO; } WaitEventIO;