From 8bf5af2ee6ea82a79817692de94347086da96b43 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Wed, 22 Feb 2023 14:22:13 +0900 Subject: [PATCH] Fix small memory leak in psql's \bind command psql_scan_slash_option() returns a malloc()'d result through a PQExpBuffer, and exec_command_bind() was doing an extra allocation of this option for no effect. Introduced in 5b66de3. Author: Kyotaro Horiguchi Reviewed-by: Corey Huinker Discussion: https://postgr.es/m/20230221.115555.89096938631423206.horikyota.ntt@gmail.com --- src/bin/psql/command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/psql/command.c b/src/bin/psql/command.c index b5201edf55..955397ee9d 100644 --- a/src/bin/psql/command.c +++ b/src/bin/psql/command.c @@ -480,7 +480,7 @@ exec_command_bind(PsqlScanState scan_state, bool active_branch) nalloc = nalloc ? nalloc * 2 : 1; pset.bind_params = pg_realloc_array(pset.bind_params, char *, nalloc); } - pset.bind_params[nparams - 1] = pg_strdup(opt); + pset.bind_params[nparams - 1] = opt; } pset.bind_nparams = nparams;