mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pg_upgrade: remove --single-transaction usage

Browse Source 
With AtEOXact applied, --single-transaction makes pg_restore slower, and
has the potential to require lock table configuration, so remove the
argument.

Per suggestion from Tom.
This commit is contained in:
Bruce Momjian 2013-01-22 22:27:13 -05:00
parent 21c87a0d46
commit 861ad67bd9
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
contrib/pg_upgrade/pg_upgrade.c
View File

@ -314,12 +314,11 @@ create_new_objects(void)
snprintf(log_file_name, sizeof(log_file_name), DB_DUMP_LOG_FILE_MASK, old_db->db_oid); snprintf(log_file_name, sizeof(log_file_name), DB_DUMP_LOG_FILE_MASK, old_db->db_oid);
/* /*
* Using pg_restore --single-transaction is faster than other * pg_dump only produces its output at the end, so there is little
* methods, like --jobs. pg_dump only produces its output at the * parallelism if using the pipe.
* end, so there is little parallelism using the pipe.
*/ */
parallel_exec_prog(log_file_name, NULL, parallel_exec_prog(log_file_name, NULL,
"\"%s/pg_restore\" %s --exit-on-error --single-transaction --verbose --dbname \"%s\" \"%s\"", "\"%s/pg_restore\" %s --exit-on-error --verbose --dbname \"%s\" \"%s\"",
new_cluster.bindir, cluster_conn_opts(&new_cluster), new_cluster.bindir, cluster_conn_opts(&new_cluster),
old_db->db_name, sql_file_name); old_db->db_name, sql_file_name);
} }