mirrors
/
postgres
mirror of https://github.com/postgres/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add PG_TEST_PG_COMBINEBACKUP_MODE to CI tasks 

The environment variable PG_TEST_PG_COMBINEBACKUP_MODE has been
available since 35a7b288b9, but was not set by any built-in CI tasks.
This commit modifies two of the CI tasks to use the alternative modes,
to exercise the pg_combinebackup code.

The Linux task uses --copy-file-range, macOS uses --clone.

This is not an exhaustive test of combinations. The supported modes
depend on the operating system and filesystem, and it would be nice to
test all supported combinations. Right now we have just one task for
each OS, and it doesn't seem worth adding more just for this.

Reported-by: Peter Eisentraut
Reviewed-by: Peter Eisentraut
Discussion: https://postgr.es/m/48da4a1f-ccd9-4988-9622-24f37b1de2b4%40eisentraut.org
This commit is contained in:
Tomas Vondra 2024-09-10 16:27:55 +02:00
parent 390b3cbbb2
commit 861086493f
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.cirrus.tasks.yml
View File

@ -321,6 +321,7 @@ task:
env: env:
SANITIZER_FLAGS: -fsanitize=address SANITIZER_FLAGS: -fsanitize=address
PG_TEST_PG_COMBINEBACKUP_MODE: --copy-file-range
# Normally, the "relation segment" code basically has no coverage in our # Normally, the "relation segment" code basically has no coverage in our
# tests, because we (quite reasonably) don't generate tables large # tests, because we (quite reasonably) don't generate tables large
@ -435,6 +436,7 @@ task:
CXXFLAGS: -Og -ggdb CXXFLAGS: -Og -ggdb
PG_TEST_PG_UPGRADE_MODE: --clone PG_TEST_PG_UPGRADE_MODE: --clone
PG_TEST_PG_COMBINEBACKUP_MODE: --clone
<<: *macos_task_template <<: *macos_task_template