mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve some comments in pg_checksums about the needed clean shutdown

Browse Source 
It was not clear from the code why it is necessary.  And we need a clean
shutdown to avoid random checksum failures caused by torn pages.

Author: Masahiko Sawada
Discussion: https://postgr.es/m/CAD21AoDum5MbAb7F=pa9dOD1W2tukuDMPzWT7NjZceNoWB_6Qw@mail.gmail.com
This commit is contained in:
Michael Paquier 2019-06-07 20:48:39 +09:00
parent 77b68e3a4f
commit 84d4de97e8
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/bin/pg_checksums/pg_checksums.c
View File

@ -475,7 +475,7 @@ main(int argc, char *argv[])
exit(1); exit(1);
} }
/* Check if cluster is running */ /* Read the control file and check compatibility */
ControlFile = get_controlfile(DataDir, &crc_ok); ControlFile = get_controlfile(DataDir, &crc_ok);
if (!crc_ok) if (!crc_ok)
{ {
@ -497,6 +497,11 @@ main(int argc, char *argv[])
exit(1); exit(1);
} }
/*
* Check if cluster is running. A clean shutdown is required to avoid
* random checksum failures caused by torn pages. Note that this doesn't
* guard against someone starting the cluster concurrently.
*/
if (ControlFile->state != DB_SHUTDOWNED && if (ControlFile->state != DB_SHUTDOWNED &&
ControlFile->state != DB_SHUTDOWNED_IN_RECOVERY) ControlFile->state != DB_SHUTDOWNED_IN_RECOVERY)
{ {