From 7d5b403b8d418742b734f85fda32b0eca8ee4113 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Fri, 18 May 2018 12:10:19 -0400 Subject: [PATCH] Small improvement for plpgsql regression test. Use DISCARD PLANS instead of a reconnect to force reconstruction of a cached plan; this corresponds more nearly to what people might actually do in practice. --- src/pl/plpgsql/src/expected/plpgsql_record.out | 6 ++++-- src/pl/plpgsql/src/sql/plpgsql_record.sql | 7 +++++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/pl/plpgsql/src/expected/plpgsql_record.out b/src/pl/plpgsql/src/expected/plpgsql_record.out index 29e42fda6c..6ea88b3de0 100644 --- a/src/pl/plpgsql/src/expected/plpgsql_record.out +++ b/src/pl/plpgsql/src/expected/plpgsql_record.out @@ -424,9 +424,11 @@ select sillyaddone(42); alter table mutable drop column f1; alter table mutable add column f1 float8; -- currently, this fails due to cached plan for "r.f1 + 1" expression +-- (but we can't actually show that, because a CLOBBER_CACHE_ALWAYS build +-- will succeed) -- select sillyaddone(42); -\c - --- but it's OK after a reconnect +-- but it's OK if we force plan rebuilding +discard plans; select sillyaddone(42); sillyaddone ------------- diff --git a/src/pl/plpgsql/src/sql/plpgsql_record.sql b/src/pl/plpgsql/src/sql/plpgsql_record.sql index 781ccb0ccb..aba6887994 100644 --- a/src/pl/plpgsql/src/sql/plpgsql_record.sql +++ b/src/pl/plpgsql/src/sql/plpgsql_record.sql @@ -274,9 +274,12 @@ alter table mutable drop column f1; alter table mutable add column f1 float8; -- currently, this fails due to cached plan for "r.f1 + 1" expression +-- (but we can't actually show that, because a CLOBBER_CACHE_ALWAYS build +-- will succeed) -- select sillyaddone(42); -\c - --- but it's OK after a reconnect + +-- but it's OK if we force plan rebuilding +discard plans; select sillyaddone(42); alter table mutable drop column f1;