mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add "break"s to make it clearer what will happen in a nested switch.

Browse Source 
This could only matter if the guessed_type variable had a value that wasn't
a member of the PasswordType enum; but just in case, let's be sure that
control falls out to reach the elog(ERROR) at the end of the function.
Per gripe from Coverity.
This commit is contained in:
Tom Lane 2017-03-12 16:01:33 -04:00
parent 835cc11367
commit 766f7fd613
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/libpq/crypt.c
View File

@ -162,6 +162,7 @@ encrypt_password(PasswordType target_type, const char *role,
case PASSWORD_TYPE_MD5: case PASSWORD_TYPE_MD5:
return pstrdup(password); return pstrdup(password);
} }
break;
case PASSWORD_TYPE_SCRAM: case PASSWORD_TYPE_SCRAM:
switch (guessed_type) switch (guessed_type)
@ -178,6 +179,7 @@ encrypt_password(PasswordType target_type, const char *role,
case PASSWORD_TYPE_SCRAM: case PASSWORD_TYPE_SCRAM:
return pstrdup(password); return pstrdup(password);
} }
break;
} }
/* /*