mirror of https://github.com/postgres/postgres
Fix ancient thinko in default table rowcount estimation.
The code used sizeof(ItemPointerData) where sizeof(ItemIdData) is correct, since we're trying to account for a tuple's line pointer. Spotted by Tomonari Katsumata (bug #12584). Although this mistake is of very long standing, no back-patch, since it's a relatively harmless error and changing it would risk changing default planner behavior in stable branches. (I don't see any change in regression test outputs here, but the buildfarm may think differently.)
This commit is contained in:
parent
4c34dcf97f
commit
75df6dc083
|
@ -509,7 +509,7 @@ estimate_rel_size(Relation rel, int32 *attr_widths,
|
|||
|
||||
tuple_width = get_rel_data_width(rel, attr_widths);
|
||||
tuple_width += sizeof(HeapTupleHeaderData);
|
||||
tuple_width += sizeof(ItemPointerData);
|
||||
tuple_width += sizeof(ItemIdData);
|
||||
/* note: integer division is intentional here */
|
||||
density = (BLCKSZ - SizeOfPageHeaderData) / tuple_width;
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue