mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update comment in heapgetpage() regarding PD_ALL_VISIBLE vs. Hot Standby.

Browse Source 
Pavan Deolasee, slightly modified by me
This commit is contained in:
Robert Haas 2012-12-14 15:44:38 -05:00
parent fdb67eb2b6
commit 75758a6ff0
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/backend/access/heap/heapam.c
View File

@ -260,10 +260,23 @@ heapgetpage(HeapScanDesc scan, BlockNumber page)
/* /*
* If the all-visible flag indicates that all tuples on the page are * If the all-visible flag indicates that all tuples on the page are
* visible to everyone, we can skip the per-tuple visibility tests. But * visible to everyone, we can skip the per-tuple visibility tests.
* not in hot standby mode. A tuple that's already visible to all *
* Note: In hot standby, a tuple that's already visible to all
* transactions in the master might still be invisible to a read-only * transactions in the master might still be invisible to a read-only
* transaction in the standby. * transaction in the standby. We partly handle this problem by tracking
* the minimum xmin of visible tuples as the cut-off XID while marking a
* page all-visible on master and WAL log that along with the visibility
* map SET operation. In hot standby, we wait for (or abort) all
* transactions that can potentially may not see one or more tuples on the
* page. That's how index-only scans work fine in hot standby. A crucial
* difference between index-only scans and heap scans is that the
* index-only scan completely relies on the visibility map where as heap
* scan looks at the page-level PD_ALL_VISIBLE flag. We are not sure if the
* page-level flag can be trusted in the same way, because it might get
* propagated somehow without being explicitly WAL-logged, e.g. via a full
* page write. Until we can prove that beyond doubt, let's check each
* tuple for visibility the hard way.
*/ */
all_visible = PageIsAllVisible(dp) && !snapshot->takenDuringRecovery; all_visible = PageIsAllVisible(dp) && !snapshot->takenDuringRecovery;