mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix portability issues with stddev in pg_stat_statements

Browse Source 
Stddev is calculated on the fly, and the code in commit 717f70953264 was
using Float8GetDatumFast() inappropriately to convert the result to a
Datum. Mea culpa. It now uses Float8GetDatum().
This commit is contained in:
Andrew Dunstan 2015-03-27 17:29:59 -04:00
parent 717f709532
commit 735cd6128a
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
contrib/pg_stat_statements/pg_stat_statements.c
View File

@ -1577,12 +1577,15 @@ pg_stat_statements_internal(FunctionCallInfo fcinfo,
* sample variance, as we have data for the whole population, * sample variance, as we have data for the whole population,
* so Bessel's correction is not used, and we don't divide by * so Bessel's correction is not used, and we don't divide by
* tmp.calls - 1. * tmp.calls - 1.
*
* We're calculating the stddev on the fly, so it's not in the tmp
* structure, so we can't use the Float8GetDatumFast macro here.
*/ */
if (tmp.calls > 1) if (tmp.calls > 1)
values[i++] = values[i++] =
Float8GetDatumFast(sqrtd(tmp.sum_var_time / tmp.calls)); Float8GetDatum(sqrtd(tmp.sum_var_time / tmp.calls));
else else
values[i++] = Float8GetDatumFast(0.0); values[i++] = Float8GetDatum(0.0);
} }
values[i++] = Int64GetDatumFast(tmp.rows); values[i++] = Int64GetDatumFast(tmp.rows);
values[i++] = Int64GetDatumFast(tmp.shared_blks_hit); values[i++] = Int64GetDatumFast(tmp.shared_blks_hit);