mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid masking a function parameter name with a local variable name.

Browse Source 
No actual bug here, but it might confuse readers, so change the name
of the local variable.

Ashutosh Bapat
This commit is contained in:
Tom Lane 2016-11-23 16:26:40 -05:00
parent bd673e8e86
commit 6fa391be4e
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/backend/optimizer/path/joinpath.c
View File

@ -131,7 +131,7 @@ add_paths_to_joinrel(PlannerInfo *root,
*/ */
foreach(lc, root->join_info_list) foreach(lc, root->join_info_list)
{ {
SpecialJoinInfo *sjinfo = (SpecialJoinInfo *) lfirst(lc); SpecialJoinInfo *sjinfo2 = (SpecialJoinInfo *) lfirst(lc);
/* /*
* SJ is relevant to this join if we have some part of its RHS * SJ is relevant to this join if we have some part of its RHS
@ -140,19 +140,19 @@ add_paths_to_joinrel(PlannerInfo *root,
* join has already been proven legal.) If the SJ is relevant, it * join has already been proven legal.) If the SJ is relevant, it
* presents constraints for joining to anything not in its RHS. * presents constraints for joining to anything not in its RHS.
*/ */
if (bms_overlap(joinrel->relids, sjinfo->min_righthand) && if (bms_overlap(joinrel->relids, sjinfo2->min_righthand) &&
!bms_overlap(joinrel->relids, sjinfo->min_lefthand)) !bms_overlap(joinrel->relids, sjinfo2->min_lefthand))
extra.param_source_rels = bms_join(extra.param_source_rels, extra.param_source_rels = bms_join(extra.param_source_rels,
bms_difference(root->all_baserels, bms_difference(root->all_baserels,
sjinfo->min_righthand)); sjinfo2->min_righthand));
/* full joins constrain both sides symmetrically */ /* full joins constrain both sides symmetrically */
if (sjinfo->jointype == JOIN_FULL && if (sjinfo2->jointype == JOIN_FULL &&
bms_overlap(joinrel->relids, sjinfo->min_lefthand) && bms_overlap(joinrel->relids, sjinfo2->min_lefthand) &&
!bms_overlap(joinrel->relids, sjinfo->min_righthand)) !bms_overlap(joinrel->relids, sjinfo2->min_righthand))
extra.param_source_rels = bms_join(extra.param_source_rels, extra.param_source_rels = bms_join(extra.param_source_rels,
bms_difference(root->all_baserels, bms_difference(root->all_baserels,
sjinfo->min_lefthand)); sjinfo2->min_lefthand));
} }
/* /*