mirrors
/
postgres
mirror of https://github.com/postgres/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Correctly handle test durations of more than 2147s in pg_test_timing. 

Previously the computation of the total test duration, measured in
microseconds, accidentally overflowed due to accidentally using signed
32bit arithmetic.  As the only consequence is that pg_test_timing
invocations with such, overly large, durations never finished the
practical consequences of this bug are minor.

Pointed out by Coverity.

Backpatch to 9.2 where pg_test_timing was added.
This commit is contained in:
Andres Freund 2015-01-04 15:44:49 +01:00
parent 029e41afd2
commit 6f9b84a401
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/pg_test_timing/pg_test_timing.c
View File

@ -115,7 +115,7 @@ test_timing(int32 duration)
static int64 histogram[32];
char buf[100];
total_time = duration > 0 ? duration * 1000000 : 0;
total_time = duration > 0 ? duration * INT64CONST(1000000) : 0;
INSTR_TIME_SET_CURRENT(start_time);
cur = INSTR_TIME_GET_MICROSEC(start_time);