mirrors
/
postgres
mirror of https://github.com/postgres/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix failure with perlcritic in psql's create_help.pl 

No buildfarm members have reported that yet, but a recently-refreshed
Debian host did.

Reviewed-by: Andrew Dunstan
Discussion: https://postgr.es/m/Y8ey5z4Nav62g4/K@paquier.xyz
Backpatch-through: 11
This commit is contained in:
Michael Paquier 2023-01-19 10:01:53 +09:00
parent a3b65fb282
commit 6ba6306256
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/bin/psql/create_help.pl
View File

@ -44,7 +44,7 @@ my $define = $hfilebasename;
$define =~ tr/a-z/A-Z/;
$define =~ s/\W/_/g;
opendir(DIR, $docdir)
opendir(my $dh, $docdir)
or die "$0: could not open documentation source dir '$docdir': $!\n";
open(my $hfile_handle, '>', "$outdir/$hfile")
or die "$0: could not open output file '$hfile': $!\n";
@ -103,7 +103,7 @@ my $maxlen = 0;
my %entries;
foreach my $file (sort readdir DIR)
foreach my $file (sort readdir $dh)
{
my ($cmdid, @cmdnames, $cmddesc, $cmdsynopsis);
$file =~ /\.sgml$/ or next;
@ -230,4 +230,4 @@ print $hfile_handle "
close $cfile_handle;
close $hfile_handle;
close $depfile_handle if ($depfile);
closedir DIR;
closedir $dh;